Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Divider 컴포넌트 구현 #160

Merged
merged 4 commits into from
Oct 30, 2024
Merged

feat: Divider 컴포넌트 구현 #160

merged 4 commits into from
Oct 30, 2024

Conversation

nijuy
Copy link
Collaborator

@nijuy nijuy commented Oct 28, 2024

1️⃣ 어떤 작업을 했나요? (Summary)

image

2️⃣ 알아두시면 좋아요!

  • 피그마를 보니 방향 전환이 가능하지 않아서 hr 태그로 구현했습니다

  • 보통 HTML 요소를 확장하는 컴포넌트는 Props 타입이 HTMLAttribute를 확장하게 만들었는데
    hr은 지원 중단된 게 대부분이길래 확장 X 했읍니다

    image

3️⃣ 추후 작업

  • 리뷰 반영 아자아자 화이팅

4️⃣ 체크리스트 (Checklist)

  • main 브랜치의 최신 코드를 pull 받았나요?

@nijuy nijuy self-assigned this Oct 28, 2024
@nijuy nijuy linked an issue Oct 28, 2024 that may be closed by this pull request
feat: Divider 컴포넌트 구현 #159
Closed
fecapark
fecapark approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@fecapark fecapark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nijuy nijuy merged commit 4ce4b2d into develop Oct 30, 2024
1 check passed
@nijuy nijuy deleted the feat/#159-divider branch October 30, 2024 11:16
@nijuy nijuy added the feat label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fecapark fecapark fecapark approved these changes

@seocylucky seocylucky Awaiting requested review from seocylucky seocylucky is a code owner

Assignees

@nijuy nijuy

Labels
feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Divider 컴포넌트 구현
2 participants
@nijuy @fecapark