-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Toast 구현 #18
Merged
Merged
feat: Toast 구현 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* SemanticTextColor 타입에 textBright를 추가했습니다.
- export const ~ 형식으로 수정했습니다.
Hanna922
reviewed
Nov 5, 2023
- useToast에서 사용되지 않는 UseToastProps 타입과 관련 import문을 삭제했습니ㅏㄷ
- long Toast에서 FADE_DURATION을 사용하도록 수정했습니다
Hanna922
approved these changes
Nov 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니당~!!!👍🏻👍🏻👍🏻 개인적으로 Toast 이름은 그대로 둬도 괜찮을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1️⃣ 어떤 작업을 했나요? (Summary)
기존 코드에 영향을 미치지 않는 변경사항
textBright
색상 추가 (Toast + 추후 Tooltip, Chip에서 사용)<Toast>
컴포넌트 추가거북이 같은 속도로
useToast
훅 추가...🐢2️⃣ 알아두시면 좋아요!
애니메이션 속도와 timing-function은 노션 참고했습니다
애니메이션 속도는 상수로 정의해놓고 썼습니다.
FADE_DURATION
은 Toast가 뜰 때 / 지워질 때 걸리는 시간이고, 이외는 Toast 유지 시간을 의미해요~!제가...... 이전 YDS에서
ToastMessage
라는 이름으로 구현되어 있는 걸 구현 끝나고 알았습니다 ^^....일단은
Toast
로 구현한 거 냅뒀는디 이 부분 이름 수정 필요하다 느끼시면ToastMessage
로 고칠게용~!3️⃣ 추후 작업
Toast
문서 작성4️⃣ 체크리스트 (Checklist)
main
브랜치의 최신 코드를pull
받았나요?(feat: <Picker> 구현 #14 머지 되면 한번 더 pull 해올게용)