Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix docker-build-and-push-arm64 #136

Closed
wants to merge 3 commits into from
Closed

fix: fix docker-build-and-push-arm64 #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2cf0051
MUST REVERT
youtalk Nov 22, 2024
ceb38d2
change to 16vcpu
youtalk Nov 22, 2024
f74b21a
remove cache-from/to
youtalk Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions .github/workflows/docker-build-and-push-arm64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: docker-build-and-push-arm64

on:
pull_request:
push:
branches:
- main
Expand All @@ -13,7 +14,7 @@

docker-build-and-push:
needs: load-env
runs-on: buildjet-8vcpu-ubuntu-2204-arm
runs-on: buildjet-16vcpu-ubuntu-2204-arm

Check warning on line 17 in .github/workflows/docker-build-and-push-arm64.yaml

View workflow job for this annotation

GitHub Actions / spell-check-differential 

Unknown word (buildjet)

Check warning on line 17 in .github/workflows/docker-build-and-push-arm64.yaml

View workflow job for this annotation

GitHub Actions / spell-check-differential 

Unknown word (vcpu)
steps:
- name: Check if PR author is the specific user
id: author-check
Expand Down Expand Up @@ -63,9 +64,6 @@
*.args.ROS_DISTRO=${{ needs.load-env.outputs.rosdistro }}
*.args.BASE_IMAGE=${{ needs.load-env.outputs.base_image }}
*.args.LIB_DIR=aarch64
*.cache-from=type=registry,ref=${{ github.repository }}-buildcache:arm64-${{ github.ref_name }}
*.cache-from=type=registry,ref=${{ github.repository }}-buildcache:arm64-main
*.cache-to=type=registry,ref=${{ github.repository }}-buildcache:arm64-${{ github.ref_name }},mode=max
dockerhub-token: ${{ secrets.DOCKERHUB_TOKEN }}

- name: Show disk space
Expand All @@ -75,7 +73,7 @@

docker-build-and-push-cuda:
needs: [load-env, docker-build-and-push]
runs-on: buildjet-16vcpu-ubuntu-2204-arm

Check warning on line 76 in .github/workflows/docker-build-and-push-arm64.yaml

View workflow job for this annotation

GitHub Actions / spell-check-differential 

Unknown word (buildjet)

Check warning on line 76 in .github/workflows/docker-build-and-push-arm64.yaml

View workflow job for this annotation

GitHub Actions / spell-check-differential 

Unknown word (vcpu)
steps:
- name: Check out repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -111,9 +109,6 @@
*.args.ROS_DISTRO=${{ needs.load-env.outputs.rosdistro }}
*.args.BASE_IMAGE=${{ needs.load-env.outputs.base_image }}
*.args.LIB_DIR=aarch64
*.cache-from=type=registry,ref=${{ github.repository }}-buildcache:arm64-${{ github.ref_name }}
*.cache-from=type=registry,ref=${{ github.repository }}-buildcache:arm64-main
*.cache-to=type=registry,ref=${{ github.repository }}-buildcache:arm64-${{ github.ref_name }},mode=max
dockerhub-token: ${{ secrets.DOCKERHUB_TOKEN }}

- name: Show disk space
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/health-check-arm64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

docker-build:
needs: load-env
runs-on: buildjet-8vcpu-ubuntu-2204-arm
runs-on: buildjet-16vcpu-ubuntu-2204-arm

Check warning on line 14 in .github/workflows/health-check-arm64.yaml

View workflow job for this annotation

GitHub Actions / spell-check-differential 

Unknown word (buildjet)

Check warning on line 14 in .github/workflows/health-check-arm64.yaml

View workflow job for this annotation

GitHub Actions / spell-check-differential 

Unknown word (vcpu)
steps:
# https://github.com/actions/checkout/issues/211
- name: Change permission of workspace
Expand Down
Loading