-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add container to symbolize crashpad crashes #778
Add container to symbolize crashpad crashes #778
Conversation
0faf59b
to
c8b7ed8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #778 +/- ##
==========================================
- Coverage 58.18% 57.58% -0.61%
==========================================
Files 1774 1905 +131
Lines 84528 94729 +10201
==========================================
+ Hits 49186 54551 +5365
- Misses 35342 40178 +4836 ☔ View full report in Codecov by Sentry. |
@lamdbui I believe this is ready for you to try out |
9790e08
to
63d388b
Compare
63d388b
to
fbc50ff
Compare
@kaidokert and @arjungm could you two review the docker syntax and ensure it's follow best practice? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - with the big caveat that i'd move most of this code to container runtime, rather than build-time. Fine to go in as is as a first pass, if you want
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just wanting a small clarification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Thanks for getting this in, @andrewsavage1 !
@lamdbui Is this something you'd want in the 25.lts.1+ branch? It wouldn't make a huge difference, as the branch it's executed from doesn't affect functionality at all, but we could cherry pick it back if it would be easier for partners |
b/266761312 (cherry picked from commit 1ebccf6)
b/266761312