Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container to symbolize crashpad crashes #778

Merged
merged 7 commits into from
May 22, 2024

Conversation

andrewsavage1
Copy link
Contributor

b/266761312

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.58%. Comparing base (ede9494) to head (63d388b).
Report is 77 commits behind head on main.

Current head 63d388b differs from pull request most recent head 610dfc4

Please upload reports for the commit 610dfc4 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #778      +/-   ##
==========================================
- Coverage   58.18%   57.58%   -0.61%     
==========================================
  Files        1774     1905     +131     
  Lines       84528    94729   +10201     
==========================================
+ Hits        49186    54551    +5365     
- Misses      35342    40178    +4836     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewsavage1
Copy link
Contributor Author

@lamdbui I believe this is ready for you to try out

@andrewsavage1 andrewsavage1 marked this pull request as ready for review May 17, 2024 19:25
@andrewsavage1
Copy link
Contributor Author

@kaidokert and @arjungm could you two review the docker syntax and ensure it's follow best practice?

docker-compose.yml Outdated Show resolved Hide resolved
Copy link
Member

@kaidokert kaidokert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - with the big caveat that i'd move most of this code to container runtime, rather than build-time. Fine to go in as is as a first pass, if you want

Copy link
Contributor

@arjungm arjungm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just wanting a small clarification

docker/crashpad_symbolize/Dockerfile Show resolved Hide resolved
Copy link

@lamdbui lamdbui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thanks for getting this in, @andrewsavage1 !

@andrewsavage1 andrewsavage1 merged commit 1ebccf6 into youtube:main May 22, 2024
308 of 309 checks passed
@andrewsavage1 andrewsavage1 deleted the feature/crashpad-container branch May 22, 2024 21:51
@andrewsavage1
Copy link
Contributor Author

@lamdbui Is this something you'd want in the 25.lts.1+ branch? It wouldn't make a huge difference, as the branch it's executed from doesn't affect functionality at all, but we could cherry pick it back if it would be easier for partners

@andrewsavage1 andrewsavage1 added the cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch label Nov 22, 2024
andrewsavage1 added a commit to andrewsavage1/cobalt that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants