Merge pull request #45 from yqni13/Development

Development_v2.6.7
yqni13 · Sep 22, 2024 · a48f4ba · a48f4ba
2 parents de587fb + 54bd3a3
commit a48f4ba
Show file tree

Hide file tree

Showing 23 changed files with 265 additions and 289 deletions.
diff --git a/README.md b/README.md
@@ -1,5 +1,5 @@
 # yqni13 portfolio
-$\texttt{\color{teal}{v2.5.5}}$
+$\texttt{\color{teal}{v2.6.7}}$
 
 
 <br><br>
@@ -18,7 +18,7 @@ $\texttt{\color{teal}{v2.5.5}}$
 </div>
 <br>
 
-### <a href="https://yqni13.github.io/portfolio/home">TRY LIVE DEMO</a>
+### <a href="https://yqni13.com">WEBPAGE</a>
 
 <br>
 
@@ -104,7 +104,7 @@ My portfolio comes with two theme settings: $\textsf{\color{gray}{Dark mode}}$ &
 |Firefox | Chrome | Opera  | Edge   | DuckGo | Brave  |
 |Yes     | Yes    | Yes    | Yes    | Yes*   | Yes    |
 
-* This browser has problems displaying certain animations.
+*This browser has problems displaying certain animations.
 
 </center>
 <br>
@@ -129,14 +129,14 @@ Specified unit tests in xyz.component.spec.ts files or other tests are my last s
 ## Updates
 
 [list of all updates](src/docs/update_protocol.md)
-### $\textsf{last\ update\ 2.5.5\ >>\ {\color{pink}2.6.5}}$
-
-- $\textsf{\color{green}Change:}$ Added page scroll indicators (white arrow animation, left bottom) for the components 'about', 'cv' and 'portfolio'.
-- $\textsf{\color{red}Patch:}$ Refactored code in terms of Google Guidelines HTML/CSS.
-- $\textsf{\color{red}Patch:}$ Refactored code in terms of Google Guidelines Typescript.
-- $\textsf{\color{red}Patch:}$ Refactored code in terms of Angular Best Practices.
-- $\textsf{\color{red}Patch:}$ Refactored code to reuse user-data from parent in child component and reduce redundancy.
-- $\textsf{\color{red}Bugfix:}$ Navigating to base url redirects to 'home' component and activates nav-menu item accordingly. [Before: Redirecting to 'home' component didn't set 'Home' nav-menu item active.]
+### $\textsf{last\ update\ 2.6.5\ >>\ {\color{pink}2.6.7}}$
+
+- $\textsf{\color{green}Change:}$ Added video to landingpage and removed single profile picture for gentle appearance.
+- $\textsf{\color{green}Change:}$ Changed color of lightmode button to decrease multiple color influence in webpage color theme.
+- $\textsf{\color{green}Change:}$ Increased information link icon sizes in footer.
+- $\textsf{\color{green}Change:}$ Added portfolio card hover/touch indicator (logo coloured hand icon, left top).
+- $\textsf{\color{teal}Addition:}$ New content added to 'Portfolio' component.
+
 
 <br>
 

diff --git a/src/app/about/about.component.scss b/src/app/about/about.component.scss
@@ -75,7 +75,6 @@ h2 {
         transform: translate(15%, -15px);
         z-index: -1;
         background: var(--about-shadow);
-        // background: var(--yqni13-gradient);
         filter: blur(15px);
         width: 82%;
     }

diff --git a/src/app/app.component.html b/src/app/app.component.html
@@ -8,7 +8,8 @@
             <img 
                 class="nav-logo" 
                 src="assets/img/yqni13-small.png" 
-                alt="no logo" [routerLink]="['home']" 
+                alt="no logo" 
+                [routerLink]="['home']" 
                 (click)="expandNavMobile(true); shareDataWithHomeComp();" 
                 (keydown.enter)="expandNavMobile(true); shareDataWithHomeComp();"
             >
@@ -46,42 +47,29 @@
             >Portfolio</span>
         </li>            
         <li>
-            <span 
+            <div 
                 [ngClass]="darkMode" 
                 (click)="setLightMode()" 
                 (keydown.enter)="setLightMode()"
                 ><i class="icon-DarkMode nav-darkmode"></i>
-            </span>
-            <span 
+            </div>
+            <div 
                 [ngClass]="lightMode"
                 (click)="setDarkMode()"
                 (keydown.enter)="setDarkMode()"
                 ><i class="icon-LightMode nav-lightmode"></i>
-            </span>
+            </div>
         </li>
         <li>
-            <!-- <p class="nav-full nav-issues" (click)="openAlertMsg(); expandNavMobile(true)"
-            (keydown.enter)="openAlertMsg(); expandNavMobile(true)">-current issues-</p> -->
             <div class="link-icons">
                 <a href="https://github.com/yqni13" target="_blank"><i class="icon-GitHub"></i></a>
-                <a href="https://app.daily.dev/yqni13" target="_blank"><img src="assets/img/dailydev.png" alt="#"></a>
-                <a href="https://leetcode.com/u/yqni13/" target="_blank"><i class="icon-LeetCode"></i></a>
+                <a href="https://app.daily.dev/yqni13" target="_blank"><i class="icon-DailyDev3"></i></a>
                 <a href="https://www.xing.com/profile/Lukas_Varga2" target="_blank"><i class="icon-Xing"></i></a>
             </div>
             <p class="footer-verification"><i class="icon-CopyRight nav-copyright"></i> {{copyrightYear}}, {{OWNER}}<br>v{{version}}</p>
         </li>
-    </ul>
-
-
+    </ul>  
 </nav>
-<!-- <div class="error-msg-box" *ngIf="!isAccepted">
-    <div class="error-wrapper">
-        <p>
-            There are currently problems with the hosting of this project on GitHub => normal navigating by nav-menu works perfectly, <span class="red-msg">refreshing (F5)</span> will lead to <span class="red-msg">Error: 404</span>. I am currently working on this issue. Until issue is closed, this message is available in nav-menu '-current issues-'<br><span class="green-msg">Accept to continue.</span><br>Started: 22.06.2024, v2.2.2<br>
-        </p>
-        <a (click)="closeAlertMsg()" (keydown.enter)="closeAlertMsg()">ACCEPT</a>
-    </div>
-</div> -->
 
 
 <router-outlet><router-outlet />
diff --git a/src/app/app.component.scss b/src/app/app.component.scss
@@ -57,7 +57,13 @@ span:hover {
 }
 
 .nav-lightmode {
-    color: var(--tangerine-yellow);
+    color: var(--lightmode-yellow);
+}
+
+nav-lightmode,
+nav-darkmode {
+    width: var(--linkicons-size)!important;
+    height: var(--linkicons-size)!important;
 }
 
 ul>:last-child {
@@ -84,31 +90,21 @@ li:nth-child(2) {
 }
 
 .setVisible {
-    visibility: visible;
     display: inline;
 }
 
 .setHidden {
-    visibility:hidden;
     display: none;
 }
 
 .link-icons i {
     color: var(--navbar-content);
-    width: 20px;
-    height: 20px;
-    margin: 5px 8.5px;
-}
-
-.link-icons img {
-    width: 20px;
-    height: 20px;
-    color: var(--navbar-content);
+    width: var(--linkicons-size);
+    height: var(--linkicons-size);
     margin: 5px 8.5px;
 }
 
-.link-icons i:hover,
-.link-icons img:hover {
+.link-icons i:hover {
     opacity: 0.4;
 }
 

diff --git a/src/app/app.component.ts b/src/app/app.component.ts
@@ -19,7 +19,7 @@ export class AppComponent implements OnInit {
   private mobileNavExpanded: boolean;
   private collapseNavbarWidth: number;
   readonly OWNER: string;
-  // isAccepted = false;
+
 
   constructor(
     private router: Router,
@@ -31,7 +31,7 @@ export class AppComponent implements OnInit {
       }
     })
 
-    this.version = '2.6.5';
+    this.version = '2.6.7';
     this.darkMode = '';
     this.lightMode = '';
     this.copyrightYear = new Date().getFullYear();
@@ -48,7 +48,6 @@ export class AppComponent implements OnInit {
 
   ngOnInit() {
     this.checkThemeCookie();
-    // this.checkAlertCookie(); // TODO(yqni13): create service for custom alert
 
     this.setNavWidthDynamically(window.screen.width);
     this.setNavWidthDynamically(document.body.clientWidth);
@@ -130,30 +129,5 @@ export class AppComponent implements OnInit {
       this.setLightMode();
     }
   }
-
-  // checkAlertCookie() {
-  //   const alertCookie = localStorage.getItem("yqni13-alert");
-  //   switch(alertCookie) {
-  //     case 'true':
-  //       this.isAccepted = true;
-  //       break;
-  //     case 'false':
-  //       this.isAccepted = false;
-  //       break;
-  //     default:
-  //       this.isAccepted = false;
-  //   }
-  // }
-
-  // openAlertMsg() {
-  //   this.isAccepted = false;
-  // }
-
-  // closeAlertMsg() {
-  //   this.isAccepted = true;
-  //   localStorage.setItem('yqni13-alert', 'true');
-  // }
-
-
 }