Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements EGit history view, etc... #37

Open
wants to merge 43 commits into
base: master
Choose a base branch
from

Conversation

cypher256
Copy link

  • Fixed status bar not working after a long time
  • Fixed Eclipse default search view tree contents not shown
  • Fixed missing handle exception
  • Fixed overlapping text like the EGit history view (Issue#13)
  • Fixed not working on Eclipse 4.6 Neon (Issue#36)

This pull request contains the code is not related to the improvement.

  • Update site snapshot
  • Some formatted code

@ystrot ystrot self-assigned this Jul 18, 2016
@ystrot
Copy link
Owner

ystrot commented Jul 18, 2016

Hi Shinji,

Thanks again for your great work on Glance! Your code looks great. There are just few things I'd like to improve:

  • I think it's better to keep source and binary files separate. That's why we used googlecode platform for it and now we'll probably move to the company's website. Unfortunately I can't just apply your request and remove binary files, because they will remain in history and it will increase repo size 10+ times, which is quite redundant.
  • Not sure about com.xored.glance-updatesite-snapshot plugin, but looks like this is something specific for your fork, so we probably don't need it in the main repo.
  • README.md file is something we definitely need to have, but it should be different from the one you have.

I think the easiest way to consider these improvements would be to create a separate fork, apply all your changes as a patch, remove files we don't need in the main repo, make a single commit and provide another pull request. What do you think? Does it work for you?

@cypher256
Copy link
Author

Hi Yuri,
Thank you for confirming my request.
It''s OK, no problem. I will accept all your suggestions.

@anb0s
Copy link

anb0s commented Mar 1, 2017

I'm an user of glance plugin, Thank you for sharing :)

Just one tip about the update site location: It would be better to have the update site also at GitHub and not at corporate and accessible place to other contributors. At GitHub it's possible to put the update site to the gh-pages branch. Just clone locally to two folders glance (master branch) and glance-gh-pages (gh-pages branch only) and commit the update-site to the second clone branch gh-pages.:
Update site is then same as home-page: http://ystrot.github.io/glance/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants