-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements EGit history view, etc... #37
base: master
Are you sure you want to change the base?
Conversation
Hi Shinji, Thanks again for your great work on Glance! Your code looks great. There are just few things I'd like to improve:
I think the easiest way to consider these improvements would be to create a separate fork, apply all your changes as a patch, remove files we don't need in the main repo, make a single commit and provide another pull request. What do you think? Does it work for you? |
Hi Yuri, |
I'm an user of glance plugin, Thank you for sharing :) Just one tip about the update site location: It would be better to have the update site also at GitHub and not at corporate and accessible place to other contributors. At GitHub it's possible to put the update site to the gh-pages branch. Just clone locally to two folders glance (master branch) and glance-gh-pages (gh-pages branch only) and commit the update-site to the second clone branch gh-pages.: |
This pull request contains the code is not related to the improvement.