Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: pin tox<4.0 to workaround incompatibility with tox-pyenv #331

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

neutrinoceros
Copy link
Member

This PR isn't meant to be merged. Rather, I intend to use it as a playground to discover bugs with the upcoming new major release of tox. Best case scenario nothing breaks and we can close this.

@neutrinoceros
Copy link
Member Author

neutrinoceros commented Dec 4, 2022

turns out we do have an issue here, in that tox-pyenv depends on the py library, but doesn't declare it explicitly as a dependency. It used to work because tox itself had py as a dependency but it looks like it's going to be dropped in tox 4.0

I will report this upstream to tox-pyenv, but the project looks very much unmaintained (no updates at all in 5 years), so I'm don't have much hope of getting an answer there.

edit: here's the report: tox-dev/tox-pyenv#21

@ngoldbaum
Copy link
Member

I guess we could vendor it if it's unmaintained, I think the uses of py are pretty easy to patch out so we don't need to depend on that.

@neutrinoceros
Copy link
Member Author

Actually I have hopes it might get answered as one of the maintainers also works very actively on tox itself. Hopefully we don't need to vendor this anything 🤞

@neutrinoceros
Copy link
Member Author

tox 4.0 final was just released, I assume its too late to get the smooth transition I was hoping for
https://github.com/tox-dev/tox/releases/tag/4.0.0

@neutrinoceros
Copy link
Member Author

yup. Now CI is plain broken... I opened a cross ref on the main repo tox-dev/tox#2611

@ngoldbaum
Copy link
Member

I’d pin tox<4.0 for now

@neutrinoceros
Copy link
Member Author

Going for it

@neutrinoceros neutrinoceros changed the title TST: try running tests with tox 4.0rc TST: pin tox<4.0 to workaround incompatibility with tox-pyenv Dec 7, 2022
@neutrinoceros neutrinoceros marked this pull request as ready for review December 7, 2022 17:55
@ngoldbaum ngoldbaum merged commit dc661cd into yt-project:main Dec 7, 2022
@neutrinoceros neutrinoceros deleted the test_tox4 branch December 7, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants