YT-20430: Drop EPollablePriority

c44335fe13601ff82f864a11f1947a605a91c48e
ytsaurus · Jul 13, 2024 · 48de94f · 48de94f
1 parent b922978
commit 48de94f
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 34 deletions.
diff --git a/yt/yt/core/bus/tcp/connection.cpp b/yt/yt/core/bus/tcp/connection.cpp
@@ -288,16 +288,6 @@ void TTcpConnection::RunPeriodicCheck()
     }
 }
 
-EPollablePriority TTcpConnection::GetPriority() const
-{
-    switch (MultiplexingBand_.load(std::memory_order::relaxed)) {
-        case EMultiplexingBand::RealTime:
-            return EPollablePriority::RealTime;
-        default:
-            return EPollablePriority::Normal;
-    }
-}
-
 const TString& TTcpConnection::GetLoggingTag() const
 {
     return LoggingTag_;

diff --git a/yt/yt/core/bus/tcp/connection.h b/yt/yt/core/bus/tcp/connection.h
@@ -99,7 +99,6 @@ class TTcpConnection
     TBusNetworkStatistics GetBusStatistics() const;
 
     // IPollable implementation.
-    NConcurrency::EPollablePriority GetPriority() const override;
     const TString& GetLoggingTag() const override;
     void OnEvent(NConcurrency::EPollControl control) override;
     void OnShutdown() override;

diff --git a/yt/yt/core/concurrency/pollable_detail.cpp b/yt/yt/core/concurrency/pollable_detail.cpp
@@ -14,11 +14,6 @@ void* TPollableBase::GetCookie() const
     return Cookie_.Get();
 }
 
-EPollablePriority TPollableBase::GetPriority() const
-{
-    return EPollablePriority::Normal;
-}
-
 ////////////////////////////////////////////////////////////////////////////////
 
 } // namespace NYT::NConcurrency
diff --git a/yt/yt/core/concurrency/pollable_detail.h b/yt/yt/core/concurrency/pollable_detail.h
@@ -14,8 +14,6 @@ class TPollableBase
     void SetCookie(TCookiePtr cookie) override;
     void* GetCookie() const override;
 
-    EPollablePriority GetPriority() const override;
-
 private:
     TCookiePtr Cookie_;
 };

diff --git a/yt/yt/core/concurrency/poller.h b/yt/yt/core/concurrency/poller.h
@@ -25,13 +25,6 @@ DEFINE_BIT_ENUM(EPollControl,
     ((Shutdown)     (0x400))    // Shutdown in progress  (for external use)
 );
 
-//! Poller may provide separate sets of threads for handling pollables of
-//! various priorities.
-DEFINE_ENUM(EPollablePriority,
-    ((Normal)    (0))
-    ((RealTime)  (1))
-);
-
 ////////////////////////////////////////////////////////////////////////////////
 
 //! Describes an FD-backed pollable entity.
@@ -50,10 +43,6 @@ struct IPollable
     //! Returns a human-readable string used for diagnostic purposes.
     virtual const TString& GetLoggingTag() const = 0;
 
-    //! Returns the priority of this pollable.
-    //! The result need not be stable (i.e. may vary across calls).
-    virtual EPollablePriority GetPriority() const = 0;
-
     //! Called by the poller when the appropriate event is triggered for the FD.
     virtual void OnEvent(EPollControl control) = 0;
 

diff --git a/yt/yt/core/concurrency/unittests/thread_pool_poller_ut.cpp b/yt/yt/core/concurrency/unittests/thread_pool_poller_ut.cpp
@@ -43,11 +43,6 @@ class TPollableMock
         return LoggingTag_;
     }
 
-    EPollablePriority GetPriority() const override
-    {
-        return EPollablePriority::Normal;
-    }
-
     void OnEvent(EPollControl control) override
     {
         // NB: Retry is the only event we trigger in this unittest via |IPoller::Retry|.