Skip to content

Commit

Permalink
Cosmetics
Browse files Browse the repository at this point in the history
commit_hash:d90aaaa0da419f9bda8492506c27ff3759b97c23
  • Loading branch information
sabdenovch committed Nov 18, 2024
1 parent 9ff0523 commit 6c41de0
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 19 deletions.
36 changes: 18 additions & 18 deletions yt/yt/client/api/client_common.h
Original file line number Diff line number Diff line change
Expand Up @@ -141,20 +141,20 @@ struct TSelectRowsOptionsBase
, public TSuppressableAccessTrackingOptions
{
//! Limits range expanding.
ui64 RangeExpansionLimit = 200000;
//! Limits maximum parallel subqueries.
int MaxSubqueries = std::numeric_limits<int>::max();
ui64 RangeExpansionLimit = 200'000;
//! Limits parallel subqueries by row count.
ui64 MinRowCountPerSubquery = 100'000;
i64 MinRowCountPerSubquery = 100'000;
//! Path in Cypress with UDFs.
std::optional<TString> UdfRegistryPath;
//! Limits maximum parallel subqueries.
int MaxSubqueries = std::numeric_limits<int>::max();
//! Query language syntax version.
int SyntaxVersion = 1;
//! If |true| then logging is more verbose.
bool VerboseLogging = false;
// COMPAT(lukyan)
//! Use fixed and rewritten range inference.
bool NewRangeInference = true;
//! Query language syntax version.
int SyntaxVersion = 1;
};

DEFINE_ENUM(EExecutionBackend,
Expand All @@ -169,16 +169,8 @@ struct TSelectRowsOptions
std::optional<i64> InputRowLimit;
//! If null then connection defaults are used.
std::optional<i64> OutputRowLimit;
//! Allow queries without any condition on key columns.
bool AllowFullScan = true;
//! Allow queries with join condition which implies foreign query with IN operator.
bool AllowJoinWithoutIndex = false;
//! Execution pool.
std::optional<TString> ExecutionPool;
//! If |true| then incomplete result would lead to a failure.
bool FailOnIncompleteResult = true;
//! Enables generated code caching.
bool EnableCodeCache = true;
//! Used to prioritize requests.
TUserWorkloadDescriptor WorkloadDescriptor;
//! Memory limit per execution node.
Expand All @@ -189,17 +181,25 @@ struct TSelectRowsOptions
NYson::TYsonString PlaceholderValues;
//! Native or WebAssembly execution backend.
std::optional<EExecutionBackend> ExecutionBackend;
//! Enables canonical SQL behaviour for relational operators, i.e. null </=/> value -> null.
bool UseCanonicalNullRelations = false;
//! Merge versioned rows from different stores when reading.
bool MergeVersionedRows = true;
//! Expected schemas for tables in a query (used for replica fallback in replicated tables).
using TExpectedTableSchemas = THashMap<NYPath::TYPath, NTableClient::TTableSchemaPtr>;
TExpectedTableSchemas ExpectedTableSchemas;
//! Add |$timestamp:columnName| to result if read_mode is latest_timestamp.
NTableClient::TVersionedReadOptions VersionedReadOptions;
//! Explicitly allow or forbid the usage of row cache.
std::optional<bool> UseLookupCache;
//! Allow queries without any condition on key columns.
bool AllowFullScan = true;
//! Allow queries with join condition which implies foreign query with IN operator.
bool AllowJoinWithoutIndex = false;
//! If |true| then incomplete result would lead to a failure.
bool FailOnIncompleteResult = true;
//! Enables generated code caching.
bool EnableCodeCache = true;
//! Enables canonical SQL behaviour for relational operators, i.e. null </=/> value -> null.
bool UseCanonicalNullRelations = false;
//! Merge versioned rows from different stores when reading.
bool MergeVersionedRows = true;
};

struct TFallbackReplicaOptions
Expand Down
2 changes: 1 addition & 1 deletion yt/yt/client/driver/command-inl.h
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ void TSelectRowsCommandBase<
.GreaterThan(0)
.Optional(/*init*/ false);

registrar.template ParameterWithUniversalAccessor<ui64>(
registrar.template ParameterWithUniversalAccessor<i64>(
"min_row_count_per_subquery",
[] (TThis* command) -> auto& {
return command->Options.MinRowCountPerSubquery;
Expand Down

0 comments on commit 6c41de0

Please sign in to comment.