Refactor components interfaces #386
Conversation
koct9i
force-pushed
the
refactor-components-interfaces
branch
from
282418d
to
dbc03e6
Compare
| @@ -152,22 +152,23 @@ func NewComponentManager( | |||
| return nil, err | |||
| } | |||
|
|
|||
| componentStatus, err := c.Status(ctx) | |||
| componentStatus, err := c.Sync(ctx, true) | |||
There was a problem hiding this comment.
I think it is clearer semantically and easier to read Status() method for this read-only action instead less obvious Sync(ctx, true) which is look like we are syncing but dry-running.
I think tradeoff of extra method in each component should be in favour of readability in place of use in that case.
There was a problem hiding this comment.
This PR in intermediate state so there might be rough pieces. I don't like this one too.
Unfortunately there is no defined clear semantics. I'm trying to make one.
| baseExecNode | ||
| localComponent | ||
| master Component | ||
| } |
There was a problem hiding this comment.
Do you think it is ok to have server twice: inside localServerComponent struct and inside baseExecNode here?
There was a problem hiding this comment.
There is no problems with that since this is reference, not instance itself.
Split layers slightly more clearly