Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add podAntiAffinity for masters in demo cfg, fix yqlAgent count for 0.9.1 #392

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

futujaos
Copy link

No description provided.

@@ -15,6 +15,16 @@ spec:
primaryMasters:
instanceCount: 3
cellTag: 1
affinity:
Copy link
Author

@futujaos futujaos Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without it, this error will appear:

The Ytsaurus "ytdemo" is invalid: spec.primaryMasters.affinity.podAntiAffinity: Required value: Masters should be placed on different nodes

i added fix to 0.9.1 and to file without version (is it latest version?), don't know if it's applicable to previous versions

@l0kix2
Copy link
Collaborator

l0kix2 commented Nov 15, 2024

Oh, hi, Oleg

@l0kix2 l0kix2 requested a review from koct9i November 15, 2024 10:49
@l0kix2
Copy link
Collaborator

l0kix2 commented Nov 15, 2024

@koct9i what do you think? Maybe ephemeralCluster should be set in this sample instead of antiaffinity if it is just for demo purposes?

@l0kix2
Copy link
Collaborator

l0kix2 commented Nov 15, 2024

Not sure if we should change 0.9.1 also, i guess it must be checked with 0.9.1 operator and maybe it doesn't have such check yet. Not sure if we even need samples for different versions (especially old ones), I guess we need to preserve latest and maybe some of the previous and update them on release (it would also be good to test them automatically).

@futujaos
Copy link
Author

Maybe ephemeralCluster should be set in this sample instead of antiaffinity if it is just for demo purposes?

it's up to you (that is ephemeralCluster?), i just think there should be an example with multiple masters somewhere in docs, currently all examples contains only single master

@koct9i
Copy link
Collaborator

koct9i commented Nov 15, 2024

Probably we could resurrect default anti-affinity for masters (but not in form defaulter webhook) and adjust validation.

Also it would be nice to validate sample config in unit test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants