add entrypoint to cluster config #61
Conversation
| @@ -161,6 +162,8 @@ def _launcher_command(component: str, common_params: CommonSpecParams, additiona | |||
| additional_parameters) | |||
|
|
|||
| java_bin = os.path.join(common_params.java_home, 'bin', 'java') | |||
| if command := getitem(common_params.task_spec, 'command'): | |||
There was a problem hiding this comment.
Where is getitem method defined?
There was a problem hiding this comment.
I've meant to write common_params.task_spec.get('command').
| @@ -161,6 +162,8 @@ def _launcher_command(component: str, common_params: CommonSpecParams, additiona | |||
| additional_parameters) | |||
|
|
|||
| java_bin = os.path.join(common_params.java_home, 'bin', 'java') | |||
| if command := getitem(common_params.task_spec, 'command'): | |||
| java_bin = f'{command} {java_bin}' | |||
There was a problem hiding this comment.
Is custom command prepended to java_bin? I think we should explicitly add some command separators like && in this case here.
There was a problem hiding this comment.
Yes, it is being prepended, not just run before, as it is an entrypoint, so && won't work here.
|
@alextokarew has imported your pull request. If you are a Yandex employee, you can view this diff. |
|
✅ This pull request is being closed because it has been successfully merged into our internal monorepository. |
No description --- Pull Request resolved: #61 commit_hash:e13c0cdb850f48b7e42d9630528d0017413b07b0
No description provided.