fix(Groups): expand group tree on non-empty group filter [#853]

ytsaurus · Nov 27, 2024 · 54914c0 · 54914c0
1 parent 63d60fa
commit 54914c0
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 6 deletions.
diff --git a/packages/ui/src/ui/store/actions/groups.ts b/packages/ui/src/ui/store/actions/groups.ts
@@ -75,7 +75,7 @@ export function toggleGroupExpand(groupName: string) {
         const expanded = {...getGroupsExpanded(getState())};
         const current = expanded[groupName];
         if (current) {
-            delete expanded[groupName];
+            expanded[groupName] = false;
         } else {
             expanded[groupName] = true;
         }

diff --git a/packages/ui/src/ui/store/selectors/groups.ts b/packages/ui/src/ui/store/selectors/groups.ts
@@ -88,15 +88,38 @@ const getGroupsTreeFiltered = createSelector(
 );
 
 const getGroupsTreeFilteredAndExpanded = createSelector(
-    [getGroupsTreeFiltered, getGroupsExpanded],
-    (root, expanded) => {
-        const res = cloneDeep_(root);
+    [getGroupsTree, getGroupsTreeFiltered, getGroupsExpanded, getGroupsNameFilter],
+    (groupTree, groupsTreeFiltered, expandedByUser, groupNameFilter) => {
+        const expandedBySearch: Record<string, boolean> = {};
+
+        const res = cloneDeep_(groupsTreeFiltered);
+
         hammer.treeList.treeForEach(res.children, (node: GroupsTreeNode) => {
-            const {name} = node;
-            if (!expanded[name]) {
+            const isNodeMatchedFilter = groupNameFilter && node.name.includes(groupNameFilter);
+
+            if (isNodeMatchedFilter) {
+                let parentName = node.parent!;
+
+                while (groupTree[parentName]) {
+                    expandedBySearch[parentName] = true;
+                    parentName = groupTree[parentName].parent;
+                }
+            }
+        });
+
+        hammer.treeList.treeForEach(res.children, (node: GroupsTreeNode) => {
+            const userInteractedWithNode = typeof expandedByUser[node.name] !== 'undefined'
+
+            const expanded = userInteractedWithNode ? expandedByUser : expandedBySearch;
+
+            if (!expanded[node.name]) {
+                node.expanded = false;
                 node.children = [];
+            } else {
+                node.expanded = true;
             }
         });
+
         return res;
     },
 );