Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled GEO tests after fix #111

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Enabled GEO tests after fix #111

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8eb2c26
Enabled GEO tests again
qvad Jan 9, 2024
8d4f5f0
Fixed return code
qvad Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions yugabyte/run-jepsen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,11 @@
"ysql/sz.multi-key-acid",
"ysql/sz.default-value",
"ysql/sz.ol.append",
# "ysql/sz.ol.geo.append",
"ysql/sz.ol.geo.append",

# YSQL snapshot isolation
"ysql/si.ol.append",
# "ysql/si.ol.geo.append",
"ysql/si.ol.geo.append",
"ysql/si.bank",
"ysql/si.bank-contention",
"ysql/si.bank-multitable",
Expand All @@ -96,23 +96,23 @@
"tests": [
# YSQL read committed
"ysql/rc.ol.append",
# "ysql/rc.ol.geo.append",
"ysql/rc.ol.geo.append",
]
},
{
"start_version": "2.15.0.0-b1",
"tests": [
"ysql/rc.pl.append",
# "ysql/rc.pl.geo.append",
"ysql/rc.pl.geo.append",
]
},
{
"start_version": "2.17.2.0-b1",
"tests": [
"ysql/sz.pl.append",
# "ysql/sz.pl.geo.append",
"ysql/sz.pl.geo.append",
"ysql/si.pl.append",
# "ysql/si.pl.geo.append",
"ysql/si.pl.geo.append",
]
}
]
Expand Down Expand Up @@ -258,6 +258,8 @@ def send_report_to_reportportal(
logging.error(f"Code: {response.status_code} Text: {response.text}")
return False

return True
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of returning True here, should not we remove else statement and put return in if clause. That makes more sense. Because we have an if clause but no return statement there.

if response.status_code == 200:
        logging.info(f"Successfully updated attributes for launch {launch_id}")
        return True
logging.error(f"Could not update attributes for launch {launch_id}")
logging.error(f"Code: {response.status_code} Text: {response.text}")
return False



def run_cmd(cmd,
timeout=None,
Expand Down
Loading