Skip to content

Commit

Permalink
[#24374] CDC: Enable tests for optimized wal reads in TSAN
Browse files Browse the repository at this point in the history
Summary:
This diff enables running the tests for optimized WAL reads for CDC in TSAN builds.
Jira: DB-13287

Test Plan: Jenkins: test regex: .*CDCSDKConsistentStreamTest.*

Reviewers: siddharth.shah, skumar

Reviewed By: siddharth.shah

Subscribers: ycdcxcluster

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D41679
  • Loading branch information
Sumukh-Phalgaonkar committed Feb 4, 2025
1 parent fc9b50c commit 0c4e469
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions src/yb/integration-tests/cdcsdk_consistent_stream-test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1107,8 +1107,7 @@ TEST_F(CDCSDKYsqlTest, TestConsistentSnapshotWithCDCSDKConsistentStream) {
ASSERT_EQ(2020, get_changes_resp.records.size());
}

// TODO(#24374): Enable the test in TSAN once the tsan race regression is fixed in master.
TEST_F(CDCSDKConsistentStreamTest, YB_DISABLE_TEST_IN_TSAN(TestReadingOfWALSegmentBySegment)) {
TEST_F(CDCSDKConsistentStreamTest, TestReadingOfWALSegmentBySegment) {
ANNOTATE_UNPROTECTED_WRITE(FLAGS_yb_enable_cdc_consistent_snapshot_streams) = true;
ANNOTATE_UNPROTECTED_WRITE(FLAGS_log_segment_size_bytes) = 10_KB;

Expand Down Expand Up @@ -1138,8 +1137,7 @@ TEST_F(CDCSDKConsistentStreamTest, YB_DISABLE_TEST_IN_TSAN(TestReadingOfWALSegme
}
}

// TODO(#24374): Enable the test in TSAN once the tsan race regression is fixed in master.
TEST_F(CDCSDKConsistentStreamTest, YB_DISABLE_TEST_IN_TSAN(TestReadingOfWALWithUncommittedTxn)) {
TEST_F(CDCSDKConsistentStreamTest, TestReadingOfWALWithUncommittedTxn) {
ANNOTATE_UNPROTECTED_WRITE(FLAGS_yb_enable_cdc_consistent_snapshot_streams) = true;
ANNOTATE_UNPROTECTED_WRITE(FLAGS_log_segment_size_bytes) = 10_KB;

Expand Down Expand Up @@ -1173,10 +1171,7 @@ TEST_F(CDCSDKConsistentStreamTest, YB_DISABLE_TEST_IN_TSAN(TestReadingOfWALWithU
}
}

// TODO(#24374): Enable the test in TSAN once the tsan race regression is fixed in master.
TEST_F(
CDCSDKConsistentStreamTest,
YB_DISABLE_TEST_IN_TSAN(TestConsumptionContinuationAfterSegmentGC)) {
TEST_F(CDCSDKConsistentStreamTest, TestConsumptionContinuationAfterSegmentGC) {
ANNOTATE_UNPROTECTED_WRITE(FLAGS_update_min_cdc_indices_interval_secs) = 0;
ANNOTATE_UNPROTECTED_WRITE(FLAGS_cdc_state_checkpoint_update_interval_ms) = 0;
ANNOTATE_UNPROTECTED_WRITE(FLAGS_yb_enable_cdc_consistent_snapshot_streams) = true;
Expand Down

0 comments on commit 0c4e469

Please sign in to comment.