Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split basic_move_controller and navigator into separate nodes #65

Open
bit-pirate opened this issue Nov 24, 2014 · 1 comment
Open

split basic_move_controller and navigator into separate nodes #65

bit-pirate opened this issue Nov 24, 2014 · 1 comment

Comments

@bit-pirate
Copy link
Contributor

The basic_move_controller does not seem to be used inside the navigator, but only is made available through it.

Hence, I suggest to put the basic move controller into it's own node, so it can be started when needed.

@jihoonl what do you think?

@jihoonl
Copy link
Collaborator

jihoonl commented Nov 29, 2014

basic_move_controller is already independent library from navigator. So it can be used without navigator.

I considered to have basic_move_controller as independent package though. But I couldn't find any good reason to make it as independent. I kept them together with these reasons.

  • It is used in semantic_navigator.
  • It is still available as independent library.
  • It prevents # of package explosion. We already have enough number of packages to maintain.

Thus, I suggest to keep them together until we find strong desire to make them separate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants