Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[yocs_diff_drive_controller] hard-coded factor for parameter #85

Open
bit-pirate opened this issue Oct 20, 2015 · 3 comments
Open

[yocs_diff_drive_controller] hard-coded factor for parameter #85

bit-pirate opened this issue Oct 20, 2015 · 3 comments
Assignees
@bit-pirate

Comments

@bit-pirate
Copy link
Contributor

@AlexReimann I just ran across this:

[...]
dist_eps_ = dist_eps_ * 0.2;
[...]
orient_eps_ = orient_thres_ * 0.2

https://github.com/yujinrobot/yujin_ocs/blob/indigo-devel/yocs_diff_drive_pose_controller/src/diff_drive_pose_controller_ros.cpp#L113-L129

What is the reason for (was the motivation behind) using this hard-coded factor?
@bit-pirate
Copy link
Contributor Author

@stonier FYI

@AlexReimann
Copy link
Contributor

Was already there before I touched the code, question back to you ;)

@bit-pirate
Copy link
Contributor Author

Right, GitHub's blame was misleading. 😄

This factor got introduced here: fb26d5a

Will think more about it and remove if I cannot come up with a good reason for it.

@bit-pirate bit-pirate self-assigned this Oct 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bit-pirate bit-pirate

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bit-pirate @AlexReimann