Remove VTK_cartesian config key and corresponding code #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit restructures a part of the VTK source code to get rid of a few lines of unnecessary or duplicated code. The function `write_vtk_tensor` was not restructured (e.g., by just calling `write_vtk_scalar(file, h, quantity+std::to_string(i)+std::to_string(j));` inside the two for-loops and implementing an else-if-statement for the components of `pi` in `write_vtk_scalar`) because this led to an increase in runtime of 20-25% w.r.t. leaving the code duplicate.
The VTK_cartesian output included a few bugs which are quite complex to solve due to the transformation t = \tau \cosh(\eta) which leads to a spread of values over multiple Cartesian time files. Since this output was more of a pet project and is not used, this commit removes it entirely.
|
Looks good to me! |
|
Looks good to me as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #33, the plan was to fix the Cartesian VTK output since it contained a few bugs. I realized that the fix is quite complex due to the transformation$t = \tau \cdot \cosh(\eta)$ and the resulting spread of values over multiple Cartesian time files (which is not considered in the code at the moment). Furthermore, this output is probably not used by anyone and since it is not useful because of the bugs, Niklas and I decided to simply remove it. A fortunate side point is that the removal decreased runtime when VTK output is used.
What I did
What I tested
eps,mub,muq,mus,nb,nq,ns,p,pi, andTwith my changes and with thestable_ebebranch (with the same config and IC) and compared the outputs. They were identical, so my changes shouldn't have changed anything output-wise.VTK_cartesian 1in in one run and as expected it was not taken into account.@NGoetz, could you check the changes and comment or approve?
@yukarpenko, as soon as Niklas approved it would be nice if you could take a look and comment or merge.