Refactoring: Move the trailing space check into IsValidEntryIgnoringR…

…emovedField(). PiperOrigin-RevId: 598727235
yukawa · Jan 16, 2024 · ed19ccb · ed19ccb
1 parent 75f747f
commit ed19ccb
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/prediction/user_history_predictor.cc b/src/prediction/user_history_predictor.cc
@@ -1381,10 +1381,6 @@ bool UserHistoryPredictor::InsertCandidates(RequestType request_type,
       // Pop() returns nullptr when no more valid entry exists.
       break;
     }
-    if (absl::EndsWith(result_entry->key(), " ")) {
-      // Invalid user history entry from alphanumeric input.
-      continue;
-    }
     bool is_valid_candidate = false;
     if (request.request_type() == ConversionRequest::PREDICTION) {
       is_valid_candidate = true;
@@ -1518,6 +1514,11 @@ bool UserHistoryPredictor::IsValidEntryIgnoringRemovedField(
     return false;
   }
 
+  if (absl::EndsWith(entry.key(), " ")) {
+    // Invalid user history entry from alphanumeric input.
+    return false;
+  }
+
   return true;
 }