Catch UnicodeDecodeError in extract_ajax_token #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zemgin
reviewed
Oct 23, 2024
| @@ -48,7 +48,7 @@ deps = | |||
| ruff | |||
|
|
|||
| commands = | |||
| ruff request_token | |||
| ruff check request_token | |||
There was a problem hiding this comment.
Ruff changed the command we need to do at some point in the past in few months.
There was a problem hiding this comment.
See here. It needs the check command.
zemgin
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that any unicode decoding errors are caught while we load the json request body. If that's the case, return
Nonefromextract_ajax_token.This fixes the scenario where invalid
utf-8characters pass throughjson.loads()and cause the program to crash.This PR is in response to #62.