-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI for Pull Requests #8
Add CI for Pull Requests #8
Conversation
WalkthroughThis change introduces a new GitHub Actions workflow that automates the conversion of Markdown files in the Changes
Sequence Diagram(s)sequenceDiagram
participant Git as GitHub
participant Workflow as CI Workflow
participant Action as Markdown to PDF Action
participant Artifacts as Artifacts Storage
Git->>Workflow: Trigger on PR/Push
Workflow->>Git: Checkout code
Workflow->>Workflow: Clean up PDF directory
Workflow->>Action: Convert Markdown to PDF
Action->>Artifacts: Upload generated PDFs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/markdownToPdfArtifacts.yml (1 hunks)
Additional comments not posted (6)
.github/workflows/markdownToPdfArtifacts.yml (6)
1-10
: LGTM! The workflow name and triggers are appropriate.The workflow is correctly set up to trigger on pull requests and pushes to the specified paths.
12-15
: LGTM! The job configuration is appropriate.The job is correctly set up with a descriptive name and runs on
ubuntu-latest
.
17-18
: LGTM! The Checkout step is correctly configured.The step uses
actions/checkout@v4
to check out the repository.
20-21
: LGTM! The Remove old PDFs step is correctly configured.The step removes the
pdfs
directory to clean up old PDFs.
23-28
: LGTM! The Convert to PDF step is correctly configured.The step uses
baileyjm02/markdown-to-pdf@v1
with appropriate inputs for the conversion.
30-33
: LGTM! The Upload as Artifact step is correctly configured.The step uses
actions/upload-artifact@v4
to upload thepdfs
directory as an artifact.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/markdownToPdfArtifacts.yml (1 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/markdownToPdfArtifacts.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Artifactが生成されていることを確認&中身のPDFも問題なさそうなことを確認しました!
masterでPDF作るワークフローとも衝突しなさそうなので、問題なさそう
Summary by CodeRabbit