fix(ditaa): pass argument values as separate arguments

ref #1803
yuzutech · Nov 10, 2024 · bdeb6c6 · bdeb6c6
1 parent 379beba
commit bdeb6c6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/ci/tests/smoke.js b/ci/tests/smoke.js
@@ -15,6 +15,7 @@ const tests = [
   { engine: 'c4plantuml', file: 'banking-system.puml', options: {}, outputFormat: ['svg', 'pdf', 'png', 'txt'] },
   { engine: 'dbml', file: 'dbml.dbml', options: {}, outputFormat: ['svg'] },
   { engine: 'ditaa', file: 'components.ditaa', options: {}, outputFormat: ['svg'] },
+  { engine: 'ditaa', file: 'components.ditaa', options: {scale: '0.7'}, outputFormat: ['svg'] },
   { engine: 'symbolator', file: 'component.sv', options: {}, outputFormat: ['svg', 'png'] },
   { engine: 'erd', file: 'schema.erd', options: {}, outputFormat: ['svg'] },
   { engine: 'mermaid', file: 'contribute.mmd', options: {}, outputFormat: ['svg'] },

diff --git a/server/src/main/java/io/kroki/server/service/DitaaCommand.java b/server/src/main/java/io/kroki/server/service/DitaaCommand.java
@@ -38,15 +38,17 @@ public byte[] convert(String source, FileFormat format, JsonObject options) thro
     }
     String scale = options.getString("scale");
     if (scale != null) {
-      commands.add("--scale " + scale);
+      commands.add("--scale");
+      commands.add(scale);
     }
     String noShadows = options.getString("no-shadows");
     if (noShadows != null) {
       commands.add("--no-shadows");
     }
     String tabs = options.getString("tabs");
     if (tabs != null) {
-      commands.add("--tabs " + tabs);
+      commands.add("--tabs");
+      commands.add(tabs);
     }
     commands.add("-");
     return commander.execute(source.getBytes(), commands.toArray(new String[0]));