Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qwen2 5 vl new vit #1

Merged
merged 6 commits into from
Feb 2, 2025
Merged

Qwen2 5 vl new vit #1

merged 6 commits into from
Feb 2, 2025

Conversation

yixqiao
Copy link
Collaborator

@yixqiao yixqiao commented Feb 1, 2025

Add the new ViT class in vLLM to Qwen 2.5 VL, removing the huggingface pretrained dependency.

Includes changes to MLP, window-based partial attention, RMSNorm, when compared to 2 VL. Enables parallelized operations where appropriate.

Copy link

github-actions bot commented Feb 1, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Owner

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this great PR! I left a few comments and please take a look at them!

In addition, it would be great if you can show some results on

  1. Correctness verification on the ViT: We don't need to add a unit test on it but we should at least check if the embeddings generated from the same image match with the transformers implementation, in both TP=1 and TP>1 cases.
  2. Speed verification: our implementation should be at least not slower than transformers implementation.

@ywang96 ywang96 mentioned this pull request Feb 2, 2025
4 tasks
@ywang96
Copy link
Owner

ywang96 commented Feb 2, 2025

@yixqiao Thank you for the work! I will take it over from here.

@ywang96 ywang96 merged commit 0d09631 into qwen2_5_vl Feb 2, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants