[1/3]: prepare blockbeat #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull reviewers statsStats of the last 30 days for lnd:
|
Pull Request Test Coverage Report for Build 9382071970Details
💛 - Coveralls |
yyforyongyu
force-pushed
the
yy-itest-miner
branch
from
2be0eb1 to
eab41d6
Compare
yyforyongyu
force-pushed
the
yy-prepare-blockbeat
branch
from
a203f49 to
055e150
Compare
yyforyongyu
force-pushed
the
yy-itest-miner
branch
from
eab41d6 to
1d2cbf7
Compare
yyforyongyu
force-pushed
the
yy-prepare-blockbeat
branch
from
055e150 to
df60558
Compare
Pull Request Test Coverage Report for Build 9497610191Details
💛 - Coveralls |
yyforyongyu
force-pushed
the
yy-itest-miner
branch
from
1d2cbf7 to
2b12d36
Compare
yyforyongyu
force-pushed
the
yy-prepare-blockbeat
branch
from
df60558 to
0712afa
Compare
Pull Request Test Coverage Report for Build 9498816450Details
💛 - Coveralls |
yyforyongyu
force-pushed
the
yy-itest-miner
branch
from
2b12d36 to
27f82d0
Compare
yyforyongyu
force-pushed
the
yy-prepare-blockbeat
branch
from
0712afa to
8242ffd
Compare
Pull Request Test Coverage Report for Build 9546079138Details
💛 - Coveralls |
yyforyongyu
force-pushed
the
yy-prepare-blockbeat
branch
from
5762e85 to
8242ffd
Compare
Pull Request Test Coverage Report for Build 9548430627Details
💛 - Coveralls |
yyforyongyu
force-pushed
the
yy-itest-miner
branch
from
27f82d0 to
1e72278
Compare
yyforyongyu
force-pushed
the
yy-prepare-blockbeat
branch
from
8242ffd to
bc13d54
Compare
Pull Request Test Coverage Report for Build 9598606296Details
💛 - Coveralls |
yyforyongyu
force-pushed
the
yy-itest-miner
branch
from
1e72278 to
3a91c55
Compare
yyforyongyu
force-pushed
the
yy-prepare-blockbeat
branch
from
bc13d54 to
01b173c
Compare
Pull Request Test Coverage Report for Build 9646711542Details
💛 - Coveralls |
yyforyongyu
force-pushed
the
yy-itest-miner
branch
from
3a91c55 to
d53be6a
Compare
yyforyongyu
force-pushed
the
yy-prepare-blockbeat
branch
from
01b173c to
9224414
Compare
Pull Request Test Coverage Report for Build 9663141753Details
💛 - Coveralls |
yyforyongyu
force-pushed
the
yy-itest-miner
branch
from
d53be6a to
1fecfe2
Compare
yyforyongyu
force-pushed
the
yy-prepare-blockbeat
branch
from
9224414 to
3b91244
Compare
yyforyongyu
force-pushed
the
yy-itest-miner
branch
from
1fecfe2 to
3309448
Compare
yyforyongyu
force-pushed
the
yy-prepare-blockbeat
branch
from
3b91244 to
fb67045
Compare
Pull Request Test Coverage Report for Build 9701688598Details
💛 - Coveralls |
Fix a flake found in `testRPCMiddlewareInterceptor` when running in macOS.
This commit replaces `AssertTopologyChannelOpen` with `AssertChannelInGraph`, which asserts a given channel edge is found. `AssertTopologyChannelOpen` only asserts a given edge has been received via the topology subscription, while we need to make sure the channel is in the graph before continuing our tests.
Fix typo: "handhsake" to "handshake"
…st-for-blockbeat trivial: prepare itest for `blockbeat`
lnwire: add new fuzz targets
Typo Update ruby.md
These comments add nothing of value since the following line is always self-documenting: data = prefixWithMsgType(data, MsgTypeToBePrefixed)
This slightly more descriptive name distinguishes the wire message harness from the onion failure harness while also obviating the repetitive comments at every call site.
The prefixing is done every time the harness is used, so it may as well reside in the harness itself.
There are several fuzz targets that can't use the standard require.Equal check for various reasons. By adapting the harness to accept a custom equality function, we can reduce code duplication in these targets.
Simplifies the code slightly and improves the error message printed if the original and deserialized messages do not match.
We need to call `WaitForShutdown` after stopping the rpc clients of the chain backends.
…_lnwire lnwire: simplify fuzz targets
…nt-shutdown multi: fix rpcclient shutdown
Also updated the loggings. This new state will be used in the following commit.
This prepares the following commit where we now let the fee bumpr decides whether to broadcast immediately or not.
This commit changes how inputs are handled upon receiving a bump result. Previously the inputs are taken from the `BumpResult.Tx`, which is now instead being handled locally as we will remember the input set when sending the bump request, and handle this input set when a result is received.
This commit adds a new method `handleInitialBroadcast` to handle the initial broadcast. Previously we'd broadcast immediately inside `Broadcast`, which soon will not work after the `blockbeat` is implemented as the action to publish is now always triggered by a new block. Meanwhile, we still keep the option to bypass the block trigger so users can broadcast immediately by setting `Immediate` to true.
Previously in `markInputFailed`, we'd remove all inputs under the same group via `removeExclusiveGroup`. This is wrong as when the current sweep fails for this input, it shouldn't affect other inputs.
Also updated `handlePendingSweepsReq` to skip immature inputs so the returned results are the same as those in pre-0.18.0.
With the combination of the following commit we can have a more granular control over the bump result when handling it in the sweeper.
After previous commit, it should be clear that the tx may be failed to created in a `TxFailed` event. We now make sure to catch it to avoid panic.
yyforyongyu
force-pushed
the
yy-prepare-blockbeat
branch
from
91b8962 to
9333ba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares the incoming blockbeat PRs, the changes are,
BlockEpochnow has the block data instead of block header. This block data is used in the incoming blockbeat PR to query spending transactions.TxError. Inputs resulted in this state will be removed from the sweeper.