Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Es6 branch #1

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Es6 branch #1

wants to merge 7 commits into from

Conversation

z4cope
Copy link
Owner

@z4cope z4cope commented Oct 31, 2022

  • Added core files.
  • Created modules folder.
  • Separated all methods and logic in separate files.
  • Applied ES6 syntax on all the code.

@prolajumokeoni
Copy link

Hi @z4cope

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a project, that does not have a descriptive readme this is required to get a review you can use the microverse readme template

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

Copy link

@mukhammadrizooff mukhammadrizooff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @z4cope,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

  • No linter errors ✔️
  • Good implementations ✔️

Required Changes ♻️

  • [REQUIRED] Please change style.css {❌) to index.css(✔️)
    image

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@z4cope
Copy link
Owner Author

z4cope commented Oct 31, 2022

@mukhammadrizooff
Thank you so much for your time reviewing my project 😄, to fix the date & the menu problem please make sure to run this command after cloning the project npm install it will simply install the dependencies required for the project which are stored in package.json.

Copy link

@mukhammadrizooff mukhammadrizooff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @z4cope,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • No linter errors ✔️
  • Good implementations ✔️
  • Perfect design ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants