Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch trunk, frunk, battery door lock types to cover type #349

Closed
wants to merge 2 commits into from

Conversation

chrisdrackett
Copy link

fixes #348

I'm somewhat new to this, and don't know how to test, but I did my best to at least get this started.

Copy link
Collaborator

@alandtse alandtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. This is a breaking change so I'm reluctant to bring it in while we have another major breaking change being developed. @shred86 how's your ETA for your changes? Or you could just merge this PR into your set of changes.


self.name = self._name()

self.uniq_name = self._uniq_name()
self.bin_type = 0x7
self.device_class: Text = "DEVICE_CLASS_DOOR"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Text imported? It's causing a linter error.

@shred86
Copy link
Contributor

shred86 commented Oct 8, 2022

Thanks for this. This is a breaking change so I'm reluctant to bring it in while we have another major breaking change being developed. @shred86 how's your ETA for your changes? Or you could just merge this PR into your set of changes.

The rewrite does have these entities as cover types. I think I've done about as much as I can with the rewrite at this point. I've been using it on a separate HA instance for several weeks and it seems to be working well.

@alandtse
Copy link
Collaborator

This should be handled in by #341

@alandtse alandtse closed this Oct 12, 2022
@chrisdrackett chrisdrackett deleted the locktocover branch October 12, 2022 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Trunk, Frunk and Battery Door to be cover and not lock
3 participants