Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct typo in wake_up call #383

Merged
merged 1 commit into from
Dec 10, 2022
Merged

Conversation

carleeno
Copy link
Contributor

Fix a bug introduced in #379

@carleeno
Copy link
Contributor Author

@alandtse sorry about this, I totally missed it. Fortunately it's not common to reach this line of code (the car has to have gone offline since the last update when sending a command). But we probably should point release teslajsonpy for this fix before we release 3.5.0 because with enough users out there, we will see this bug pop up.

@alandtse alandtse merged commit 5209e0a into zabuldon:dev Dec 10, 2022
@alandtse
Copy link
Collaborator

I'm on mobile so can't create a PR. Can you do a PR from Dev to master please? I just date those and ignore the semantic versioning requirement.

@carleeno
Copy link
Contributor Author

I'm on mobile so can't create a PR. Can you do a PR from Dev to master please? I just date those and ignore the semantic versioning requirement.

Unfortunately it seems I'm blocked from making a PR against master. however the tesla integration doesn't have this bug yet, so it probably doesn't have to be rushed, I just wanted to make sure you saw this before cutting the next tesla integration release.

alandtse added a commit that referenced this pull request Dec 11, 2022
fix: fix typo in wake_up call (#383)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants