-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SP-GiST support #43
base: main
Are you sure you want to change the base?
SP-GiST support #43
Conversation
d63f74b
to
b1a395b
Compare
Hi! First and foremost, thank you for doing all this! It is really nice to have h3 integration in postgres :). I've been wondering that the h3 index structure fits perfectly the sp-gist indexes and found this PR. I tried to rebase this branch so it has the latest updates in main to give it a try and work on it. But it is a bit hell of a rebase 😁 and don't think I'm familiarized enough with your code to make it correctly. |
Hi @BielStela! Any help on this is appreciated, I've gone ahead and rebased the branch on main. You should be able to run the tests using the script at As far as I can tell the last test query is currently crashing the server. |
Hi, @zachasme, I managed to pass all the test by finding that the line Line 294 in e8aae9e
was the one causing the segfault. I removed the pointer definition and fixed pass by reference here and there of |
Thank you for the fix! Yes, I'm afraid the current branch is simply the result of me smashing something together that can run on a PostgreSQL server. The next (big) step is figuring out how to best implement picksplit and choose, such that the implementation is both correct and performant. May I ask how you tested that the index is as slow as not having the index? |
Replaces #7. Part of #5.
I have closed the old PR which contained code for both GiST and SP-GiST, splitting it into two separate PRs.
Currently the tests do not pass, and work is focused GiST, see #42.