Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ash 0.38 #76

Closed
wants to merge 3 commits into from
Closed

Update to ash 0.38 #76

wants to merge 3 commits into from

Conversation

realmayus
Copy link
Contributor

Update the ash package's ash version to 0.38.
I'm not sure how to update the version of gpu-alloc-ash as it seems to be synced with the gpu-alloc package.

Copy link
Owner

@zakarumych zakarumych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks alright.

No need to update gpu-alloc itself, they both communicate only via gpu-alloc-types that stay the same

@realmayus
Copy link
Contributor Author

Okay, shouldn't I bump the version of gpu-alloc-ash to 0.6.1 though?

@zakarumych
Copy link
Owner

You've changed minor version of ash, so bump minor version of crate.

@zakarumych
Copy link
Owner

zakarumych commented Apr 5, 2024

Please, update it to 0.7.0.
Or users of ash 0.37 will cargo update to incompatible version of gpu-alloc-ash

@zakarumych zakarumych closed this Apr 9, 2024
@zakarumych
Copy link
Owner

I've added changes so it would pass checks in #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants