New plugin sanitize headers #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets us closer to replacing Task2 with Task globally, and simplifies the plugin's code. Signed-off-by: Thibaut Le Page <[email protected]>
Signed-off-by: Thibaut Le Page <[email protected]>
Signed-off-by: Thibaut Le Page <[email protected]>
Signed-off-by: Thibaut Le Page <[email protected]>
Signed-off-by: Thibaut Le Page <[email protected]>
Signed-off-by: Thibaut Le Page <[email protected]>
bmaher
reviewed
Feb 20, 2019
Signed-off-by: Thibaut Le Page <[email protected]>
tortila
reviewed
Feb 20, 2019
Signed-off-by: Thibaut Le Page <[email protected]>
Signed-off-by: Thibaut Le Page <[email protected]>
|
Created: #26 to address the outstanding task from this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next step in #11: converting the Sanitize Headers plugin from the old plugin architecture (with sequences of tasks as input/output) to the new one (with, in this particular case, a task as input/output).
Description
OnTask,OnTaskSequence,OnScenario, andOnPythonProgramcontracts in Transformer, so that the corresponding plugins receive their expected inputs.typingAPI), use a basic decorator that annotates the plugin function with a private field. Contracts become elements of aContractenum instead of beingtyping.Callablespecs.transformeris used from the CLI.The new documentation about writing plugins is in the wiki.
Types of Changes
Tasks
List of tasks you will do to complete the PR: