Fix interaction between Task & Task2; add python.ExpressionView & task.RequestsPostData #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Any OnTask plugin that changes Task2.request has no effect because that field is not taken into account in Task2.statements. Fixing this by introducing python.Placeholder, a syntax node representing a non-syntax node (like a Request instance, in our case). Special care has to be taken when the Task being converted into a Task2 already has a Task.locust_request, which is kind of a copy of Task.request with a different interface. Fix #31. Signed-off-by: Thibaut Le Page <[email protected]>
It was relying on a type error all along, because Request.headers is supposed to be a List[Header], not a dict. Signed-off-by: Thibaut Le Page <[email protected]>
Signed-off-by: Thibaut Le Page <[email protected]>
Signed-off-by: Thibaut Le Page <[email protected]>
Signed-off-by: Thibaut Le Page <[email protected]>
Signed-off-by: Thibaut Le Page <[email protected]>
tortila
reviewed
Feb 25, 2019
tortila
reviewed
Feb 25, 2019
tortila
reviewed
Feb 25, 2019
bmaher
reviewed
Feb 25, 2019
Signed-off-by: Thibaut Le Page <[email protected]>
Signed-off-by: Thibaut Le Page <[email protected]>
Signed-off-by: Thibaut Le Page <[email protected]>
tortila
reviewed
Feb 26, 2019
tortila
reviewed
Feb 26, 2019
tortila
reviewed
Feb 26, 2019
tortila
reviewed
Feb 26, 2019
Signed-off-by: Thibaut Le Page <[email protected]>
Signed-off-by: Thibaut Le Page <[email protected]>
Signed-off-by: Thibaut Le Page <[email protected]>
tortila
reviewed
Feb 26, 2019
tortila
reviewed
Feb 26, 2019
Signed-off-by: Thibaut Le Page <[email protected]>
Signed-off-by: Thibaut Le Page <[email protected]>
tortila
approved these changes
Feb 26, 2019
bmaher
approved these changes
Feb 26, 2019
thilp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any OnTask plugin that changes
Task2.requesthas no effect because that field is not taken into consideration inTask2.statements(which is the only input for building the final tree).Fixing this by introducing transformer.python.Placeholder, a syntax node representing a non-syntax node (like a Request instance, in our case). See Placeholder's documentation for more details.
Special care has to be taken when the Task (being converted into a Task2) already has a
Task.locust_request, which is kind of a copy of Task.request with a different interface.Fix #31.
Types of Changes
What types of changes does your code introduce? Keep the ones that apply: