39: add jolokia for zookeeper monitoring #40
Conversation
|
👍 |
Dockerfile
Outdated
| @@ -44,7 +46,6 @@ RUN export DEBIAN_FRONTEND=noninteractive \ | |||
| && rm -rf /var/lib/apt/lists/* /root/.m2 | |||
|
|
|||
| # Base part of dockerfile should not be modified not to rebuild image for 1 hour | |||
| ENV JOLOKIA_VERSION="1.3.7" | |||
There was a problem hiding this comment.
What is the purpose of moving this variable up? The install here takes time and reordering commands will cause longer rebuild
| @@ -57,6 +58,6 @@ COPY scm-source.json /scm-source.json | |||
| WORKDIR ${HOME} | |||
| USER ${USER} | |||
|
|
|||
| EXPOSE 2181 2888 3888 8181 8778 | |||
| EXPOSE 2181 2888 3888 8181 8778 8779 | |||
There was a problem hiding this comment.
Can you please add port mapping here: https://github.com/zalando-nakadi/exhibitor-appliance/blob/master/exhibitor-appliance.yaml#L51
| @@ -11,3 +11,4 @@ election-port=3888 | |||
| zoo-cfg-extra=tickTime\=2000&initLimit\=10&syncLimit\=5&quorumListenOnAllIPs\=true | |||
| auto-manage-instances-settling-period-ms=0 | |||
| auto-manage-instances=1 | |||
| java-environment=#!/bin/bash \nexport JAVA_TOOL_OPTIONS="-javaagent:/opt/jolokia-jvm-${JOLOKIA_VERSION}-agent.jar=port=8779,host=0.0.0.0" | |||
There was a problem hiding this comment.
Can you please explain what is java-environment and how this thing is used? I failed to find documentation for it
There was a problem hiding this comment.
The value of java-environment is placed in Config -> Ensemble -> java.env script. It is "Script to write as the “java.env” file which gets executed as part of the ZooKeeper start script. Optional – leave blank for no file." docs
|
👍 |
|
@zrobgar can I ask you to review again? |
|
👍 |
ghost
closed this by deleting the head repository
Jolokia support for Zookeeper monitoring was added. #39