WIP – use NakadiMock in the spring-boot-2-test #109
+131
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ePaul
added
in progress
nakadi-submission
spring-boot-2
ePaul
commented
Dec 19, 2018
| } else if (withIdGreaterThan.equals("1")) { | ||
| return Collections.singletonList(new Snapshot("2", "foo", filter)); | ||
| return Collections.singletonList(new Snapshot("2", "foo", new Data("2", filter))); |
There was a problem hiding this comment.
Adding this so we actually get objects sent, not just null or strings.
ePaul
commented
Dec 19, 2018
| <dependency> | ||
| <groupId>org.zalando</groupId> | ||
| <artifactId>nakadi-mock</artifactId> | ||
| <version>0.0.1-SNAPSHOT</version> |
There was a problem hiding this comment.
This is currently not yet released, and if it gets released, it might be under a different group name.
ePaul
commented
Dec 19, 2018
| @@ -63,6 +69,7 @@ | |||
| <groupId>io.rest-assured</groupId> | |||
| <artifactId>rest-assured</artifactId> | |||
| <version>3.1.0</version> | |||
| <scope>test</scope> | |||
There was a problem hiding this comment.
This is unrelated, I just noted that this does need only test scope.
ePaul
commented
Dec 19, 2018
| import java.util.Collections; | ||
|
|
||
| @EnableAutoConfiguration | ||
| @EnableNakadiProducer |
There was a problem hiding this comment.
Removed the deprecated annotation here.
ePaul
commented
Dec 19, 2018
| /** | ||
| * An application context initializer which sets up a NakadiMock bean and registers the server URL as a property. | ||
| */ | ||
| class NakadiServerMockInitializer implements ApplicationContextInitializer<ConfigurableApplicationContext>{ |
There was a problem hiding this comment.
I wonder whether it makes sense to move this class into either my Nakadi-Mock or even a new artifact, as this is useful whenever we are using both nakadi-producer and nakadi-mock together.
ePaul
force-pushed
the
feature/use-nakadi-mock
branch
from
29b2f31 to
3c07ac1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of my Hackweek project. Please don't merge yet (we want to have a stable release of nakadi-mock first), but comments are already appreciated.
This is a Proof-of-concept of how to use my nakadi-mock project to test the event sending of spring-boot applications.
It turned out to be more complicated than I thought, because Spring-Boot-Autoconfigure detected that Undertow (an alternative web server, which I'm using in nakadi-mock) is on the class path, and tried to set it up as the application's web server (beside the Tomcat).
I solved that on the library side by shading undertow (renaming all class names and including in the Jar, thus removing the dependency).
Another issue is that we need to get the port number for the mock before configuring our Nakadi-Producer, which is why we are now using an ApplicationContextInitializer instead of normal
@Configurationclasses for that.Includes the changes of #107 and #108, so those should be merged first.