Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch deletion of eventlogs #171

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Batch deletion of eventlogs #171

merged 2 commits into from
Aug 2, 2023

Conversation

ePaul
Copy link
Member

@ePaul ePaul commented Jun 21, 2023

  • repository: add batch deletion method to interface (with default implementation)
  • repository: implement batch deletion (uses updateBatch)
  • test for batch deletion
  • repository: refactoring for persist
  • transmission: use batch deletion

This came up as a part of #170, but seems useful enough without it, so I'm submitting this as a separate PR.

@ePaul ePaul added spring-boot-2 Issues/PRs which only apply to the Spring-Boot 2 versions (Releases 20.*+) persistence everything around DB access labels Jun 21, 2023
@ePaul ePaul requested a review from fbrns as a code owner June 21, 2023 15:33
@ePaul ePaul mentioned this pull request Jul 28, 2023
1 task
ePaul added 2 commits July 28, 2023 19:11
* repository: add batch deletion method to interface (with default implementation)
* repository: implement batch deletion (uses updateBatch)
* transmission: use batch deletion
@ePaul
Copy link
Member Author

ePaul commented Jul 28, 2023

👍

1 similar comment
@fbrns
Copy link
Member

fbrns commented Aug 2, 2023

👍

@ePaul ePaul merged commit 5a9b887 into master Aug 2, 2023
@ePaul ePaul deleted the batch-deletion branch August 2, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
persistence everything around DB access spring-boot-2 Issues/PRs which only apply to the Spring-Boot 2 versions (Releases 20.*+)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants