introduce "switch off all submission" toggle #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ePaul
added
enhancement
auto-configuration
ePaul
force-pushed
the
disable-submission
branch
3 times, most recently
from
da11710 to
72e8869
Compare
ePaul
commented
Aug 3, 2023
ePaul
commented
Aug 3, 2023
...g-boot-starter/src/main/java/org/zalando/nakadiproducer/NakadiProducerAutoConfiguration.java
Show resolved
Hide resolved
ePaul
commented
Aug 3, 2023
Comment on lines
-152
to
+160
| @Bean | ||
| public EventTransmitter eventTransmitter(EventTransmissionService eventTransmissionService) { | ||
| return new EventTransmitter(eventTransmissionService); | ||
| } | ||
| @ConditionalOnProperty(name="nakadi-producer.submission-enabled", havingValue = "true", matchIfMissing = true) | ||
| @EnableScheduling | ||
| @Configuration | ||
| static class TransmissionConfiguration { |
There was a problem hiding this comment.
This looks a bit better when you disable whitespace in the diff.
ePaul
force-pushed
the
disable-submission
branch
2 times, most recently
from
8fe003a to
dd3122a
Compare
ePaul
force-pushed
the
disable-submission
branch
3 times, most recently
from
7c317f7 to
a2b2a0e
Compare
- auto configuration - test for non-existence of certain beans - documentation
ePaul
force-pushed
the
disable-submission
branch
from
a2b2a0e to
a0d9138
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
1 similar comment
|
👍 |
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a configuration property for completely switching off all submission to Nakadi
(including setting up the corresponding beans).
This came up as part of #170, but while writing the README, I found a separate use case for it,
so I make it a separate PR.
This includes the change from #176 ( ✔️ ), so it should be merged after that one.