-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return 'none' body filter if list of to-be-filtered JSON field-names is empty #2007
Conversation
...-autoconfigure/src/main/java/org/zalando/logbook/autoconfigure/LogbookAutoConfiguration.java
Outdated
Show resolved
Hide resolved
Wiring of default empty obfuscate filters could be avoided entirely using a custom |
Thank you for the PR! I now wonder if the check for |
ah, wait. We can't merge it as they commits are not signed. @skjolber would you be able forcepush only signed commits? |
4a547b1
to
5a6fb9d
Compare
@kasmarian better? First time signing commits. |
Yes, looks good now, thank you! |
FYI this solves #1882 (did not see the issue until just now). |
@msdousti could you re-approve? |
The Spring auto-configuration adds a body filter
JacksonJsonFieldBodyFilter
for JSON payloads without checking that there is actually some filtering to be performed.Description
The
LogbookProperties
Obfuscate
classjsonBodyFields
field defaults to empty.Add empty check, if so return noop filter.
Motivation and Context
Avoid unnecessary parse of JSON payloads.
Types of changes
Checklist: