Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider implementing riptide based on a reactive stack #328

Open
whiskeysierra opened this issue Jan 17, 2018 · 2 comments
Open

Consider implementing riptide based on a reactive stack #328

whiskeysierra opened this issue Jan 17, 2018 · 2 comments
Milestone

Comments

@whiskeysierra
Copy link
Collaborator

whiskeysierra commented Jan 17, 2018

Spring uses reactor as it's abstraction, but in the context of #837 we shouldn't be bound by that.

@whiskeysierra whiskeysierra added this to the 3.0.0 milestone Jan 17, 2018
@whiskeysierra whiskeysierra modified the milestones: 3.0.0, 4.0.0 Jul 16, 2018
@whiskeysierra whiskeysierra changed the title Consider implementing riptide based on Spring 5's WebClient Consider implementing riptide based on a reactive stack Nov 21, 2019
@whiskeysierra
Copy link
Collaborator Author

Returning a CompletableFuture is technically enough, but our current use of InputStream requires either blocking calls or at least buffering in case non-blocking IO. Neither of which is ideal when working reactive.

@whiskeysierra
Copy link
Collaborator Author

The AsyncRestTemplate also supports non-blocking interactions. The main difference is it can’t support non-blocking streaming, like for example Twitter one, because fundamentally it’s still based and relies on InputStream and OutputStream.

https://docs.spring.io/spring/docs/5.0.0.M4/spring-framework-reference/html/web-reactive.html#web-reactive-client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant