Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong bool handling of LOG_SHIP_HOURLY #1030

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Conversation

FxKu
Copy link
Member

@FxKu FxKu commented Oct 9, 2024

Setting LOG_SHIP_HOURLY to bool leads to the following error:

2024-10-08 14:52:53,562 - bootstrapping - INFO - Writing to file /run/etc/log.d/env/LOG_SHIP_HOURLY
Traceback (most recent call last):
  File "/scripts/configure_spilo.py", line 1198, in <module>
    main()
  File "/scripts/configure_spilo.py", line 1160, in main
    write_log_environment(placeholders)
  File "/scripts/configure_spilo.py", line 806, in write_log_environment
    write_file(log_env[var], os.path.join(log_env['LOG_ENV_DIR'], var), True)
  File "/scripts/spilo_commons.py", line 76, in write_file
    f.write(config)
TypeError: write() argument must be str, not bool

Not sure, why tests do not catch this, because in my test the cluster does not even start.

@FxKu FxKu added the bugfix Bug fixes and patches, e.g. fixing of a production issue that is affecting the customer experience. label Oct 9, 2024
@FxKu
Copy link
Member Author

FxKu commented Oct 9, 2024

👍

1 similar comment
@hughcapet
Copy link
Member

👍

@FxKu FxKu merged commit a321f35 into zalando:master Oct 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bug fixes and patches, e.g. fixing of a production issue that is affecting the customer experience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants