Read backup's last modification timestamp from metadata #1064
+85
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello folks,
This patch adds support for reading last modification timestamp for a particular backup from its metadata.
I've encountered a situation just like in wal-g/wal-g#1770: sometimes
wal-g backup-listreports wrong last modification timestamp, which breaks the whole point-in-time recovery process.Luckily, WAL-G has an option (
wal-g backup-list --detail) to read some additional information for the given backup from its metadata, including the needed timestamp.I've already tested the added functionality on a real PostgreSQL cluster at work and it does fix the problem. Let me know, however, if you think that some additional tests should be added.
Thanks.