chore(ci): improve build and testing workflows #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmarks would be run in GitHub Actions each time a commit is pushed into main and can also be triggered on demand on any branch. Benchmarks are executed in two flavors, one with AVX512 CPU instructions support and one without it. Results are parsed and then sent to Slab, Zama's CI bot, to be stored in database.
Builds are tested thoroughly after conformance check. All intriscis are tested and a commit check has been added. Liniting workflow had been removed due to duplication with conformance test (make pcc).
IceTDrinker
reviewed
Mar 7, 2023
|
Maybe be yes, this would create a big CI commit, unless we keep commits separated. |
|
ok to keep both commits as the second one is small I don't see a problem to squash if you wanted to |
|
Commit has been moved to #7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds are tested thoroughly after conformance check.
All intriscis are tested and a commit check has been added.
Liniting workflow had been removed due to duplication with conformance test (
make pcc).It should help resolving #6.