docs: update cifar_brevitas_training accuracy using representative calibration set #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanBredehoft
commented
Sep 8, 2023
| | VGG FHE | 6 bits | 87.5\*\* | | ||
| | VGG FHE (simulation\*) | 8 bits | 88.0 | | ||
| | VGG FHE (simulation\*) | 7 bits | 87.2 | | ||
| | VGG FHE (simulation\*) | 6 bits | 86.0 | |
There was a problem hiding this comment.
I removed the 5 bits because it gave ~60% accuracy, so not really relevant
RomanBredehoft
commented
Sep 8, 2023
| | VGG FHE (simulation\*) | 8 bits | 88.0 | | ||
| | VGG FHE (simulation\*) | 7 bits | 87.2 | | ||
| | VGG FHE (simulation\*) | 6 bits | 86.0 | | ||
| | VGG FHE | 6 bits | 86.0\*\* | |
There was a problem hiding this comment.
I'm currently executing the FHE inference on 10 samples to check for that
There was a problem hiding this comment.
jfrery
reviewed
Sep 8, 2023
EDIT: just understood your question actually, and Im also not sure how to do that (but not sure if it's really important) |
RomanBredehoft
force-pushed
the
docs/update_cifar_brevitas_training_accuracy_readme_3957
branch
from
1efa947 to
7a3839b
Compare
RomanBredehoft
changed the title
RomanBredehoft
deleted the
docs/update_cifar_brevitas_training_accuracy_readme_3957
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out there was not a bug, this is the new accuracy we should talk about. Basically, we were not properly calibrating before, but more details can be found in https://github.com/zama-ai/concrete-ml-internal/issues/3957
closes https://github.com/zama-ai/concrete-ml-internal/issues/3957