Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reorg cifar usecases #245

Merged
merged 6 commits into from
Sep 21, 2023
Merged

chore: reorg cifar usecases #245

merged 6 commits into from
Sep 21, 2023

Conversation

jfrery
Copy link
Collaborator

@jfrery jfrery commented Sep 13, 2023

No description provided.

@jfrery jfrery requested a review from a team as a code owner September 13, 2023 07:52
@cla-bot cla-bot bot added the cla-signed label Sep 13, 2023
@jfrery jfrery force-pushed the chore/reorg_cifar_usecases branch from 9cc03bd to 6461510 Compare September 13, 2023 07:54
RomanBredehoft
RomanBredehoft requested changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@RomanBredehoft RomanBredehoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks ! I addressed a few minor changes

andrei-stoian-zama
andrei-stoian-zama requested changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@andrei-stoian-zama andrei-stoian-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should explain a bit more the differences between notebooks

use_case_examples/cifar/README.md Outdated Show resolved Hide resolved
use_case_examples/cifar/README.md Outdated Show resolved Hide resolved
use_case_examples/cifar/README.md Outdated Show resolved Hide resolved
use_case_examples/cifar/README.md Outdated Show resolved Hide resolved
@jfrery jfrery force-pushed the chore/reorg_cifar_usecases branch from 5ddfe66 to eac1009 Compare September 14, 2023 07:46
@jfrery jfrery force-pushed the chore/reorg_cifar_usecases branch from eac1009 to 9540e96 Compare September 14, 2023 15:27
RomanBredehoft
RomanBredehoft previously approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@RomanBredehoft RomanBredehoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine for me, but I tend to agree with Andrei's comment

fd0r
fd0r requested changes Sep 18, 2023
View reviewed changes
use_case_examples/cifar/README.md Outdated Show resolved Hide resolved
RomanBredehoft
RomanBredehoft approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@RomanBredehoft RomanBredehoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last remaining small typo but the rest is fine for me !

@jfrery jfrery requested a review from fd0r September 21, 2023 06:40
@jfrery jfrery merged commit 5b0478b into main Sep 21, 2023
8 checks passed
@jfrery jfrery deleted the chore/reorg_cifar_usecases branch September 21, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcm-at-zama bcm-at-zama bcm-at-zama left review comments

@RomanBredehoft RomanBredehoft RomanBredehoft approved these changes

@fd0r fd0r fd0r approved these changes

@andrei-stoian-zama andrei-stoian-zama andrei-stoian-zama left review comments

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jfrery @fd0r @RomanBredehoft @bcm-at-zama @andrei-stoian-zama