-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove manual set of multi and mono strategy #256
chore: remove manual set of multi and mono strategy #256
Conversation
061b108
to
23d5cc5
Compare
Will this not impact @kcelia's PR where she needs to set MONO so CP doesn't crash ? |
I'm guessing this mono/multi issue only affects KNN so she can just set MONO in KNN dedicated test suite no? |
ah yes forgot to mention, this will conflict a bit with @kcelia's PR as I indeed removed so either I wait for her the merge and then I rebase on main (which I think is best), or I put back the function with |
Thanks @RomanBredehoft ! |
23d5cc5
to
2ea6018
Compare
2ea6018
to
96eb5f6
Compare
96eb5f6
to
9de1b2d
Compare
Coverage passed ✅Coverage details
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice clean up! I thought KNN was still needing mono params tho?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright, thanks
Recent Concrete- Python integration :
refs https://github.com/zama-ai/concrete-ml-internal/issues/3889
closes https://github.com/zama-ai/concrete-ml-internal/issues/3862
closes https://github.com/zama-ai/concrete-ml-internal/issues/3860