chore: add run use case example to GH workflow #310

jfrery · 2023-09-28T16:11:12Z

closes https://github.com/zama-ai/concrete-ml-internal/issues/3458
closes https://github.com/zama-ai/concrete-ml-internal/issues/4315

jfrery · 2023-09-28T16:11:26Z

ran in https://github.com/zama-ai/concrete-ml/actions/runs/6340447046/job/17221915611

.github/workflows/run_use_cases_examples.yaml

RomanBredehoft

looks good I think, you'll be able to test it after merging it in main anyway since it's a new workflow

jfrery · 2023-09-28T17:45:03Z

looks good I think, you'll be able to test it after merging it in main anyway since it's a new workflow

I already tested it in the link above. You can trigger a workflow by setting the on: push in a workflow file such that it runs even if not merged in main.

andrei-stoian-zama · 2023-09-29T08:26:36Z

ran in https://github.com/zama-ai/concrete-ml/actions/runs/6340447046/job/17221915611

Looks fishy to me:

2023-09-28T14:45:31.4359697Z  - Notebook KaggleTitanic.ipynb executed in 00h:01m:07s
2023-09-28T14:47:46.0308361Z  - Notebook Cifar10.ipynb executed in 00h:00m:08s
2023-09-28T14:50:05.8887772Z  - Notebook FromImageNetToCifar.ipynb executed in 00h:00m:04s
2023-09-28T14:50:10.4400263Z  - Notebook CifarQuantizationAwareTraining.ipynb executed in 00h:00m:05s
2023-09-28T14:50:18.0455244Z  - Notebook CifarInFhe.ipynb executed in 00h:00m:08s
2023-09-28T14:50:23.6504987Z  - Notebook CifarInFheWithSmallerAccumulators.ipynb executed in 00h:00m:05s
2023-09-28T15:01:09.0179678Z  - Notebook SentimentClassification.ipynb executed in 00h:00m:08s

RomanBredehoft · 2023-12-13T16:11:27Z

why was this closed @jfrery ?

jfrery · 2023-12-13T16:35:36Z

Not sure if this is useful. We never needed it.

use_case_examples/titanic/Makefile

use_case_examples/titanic/requirements.txt

benchmarks/glm.py

src/concrete/ml/quantization/base_quantized_op.py

use_case_examples/cifar/cifar_brevitas_finetuning/cifar_utils.py

RomanBredehoft · 2024-04-17T13:01:46Z

use_case_examples/cifar/cifar_brevitas_training/Makefile

@@ -2,11 +2,14 @@
 export LC_ALL=en_US.UTF-8
 export LANG=en_US.UTF-8

-EXAMPLE_NAME=cifar_brevitas_finetuning
+EXAMPLE_NAME=cifar_brevitas_training


here and in the following makefiles, I believe the EXAMPLE_NAME and JUPYTER_RUN are useless as only TIME_NB is used to run the notebooks/files

so I would remove them as it's a bit confusing why we have two jupyter nbconvert --to notebook --inplace --execute occurences (here and in time_notebook_execution.sh)

Yes bad copy paste here thanks!

I see that you kept EXAMPLE_NAME here (and below), are these necessary ? I don't see how they are used !

also I can see some jupyter nbconvert --to notebook --inplace --execute in some makefiles below, so I guess you're not finished !

Nice catch. I am not using the folder name as example name to print logs. This can be remove. Let me clean the Makefile.

thanks for cleaning up things ! I still see one remaining EXAMPLE_NAME in this exact makefile, but the other ones look fine

Indeed bad rebase. It's fixed

script/make_utils/run_use_case_examples.sh

use_case_examples/cifar/cifar_brevitas_training/Makefile

use_case_examples/deployment/breast_cancer_builtin/Makefile

use_case_examples/deployment/cifar_8_bit/Makefile

use_case_examples/deployment/sentiment_analysis/Makefile

RomanBredehoft

looks great, thanks a lot !

github-actions · 2024-04-18T13:32:56Z

Coverage passed ✅

Coverage details

---------- coverage: platform linux, python 3.8.18-final-0 -----------
Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL    7548      0   100%

59 files skipped due to complete coverage.

fd0r

Might be a dumb question but don't we also want to open a PR with the new run of the use-case or is this just for testing purposes? (cc @jfrery )

jfrery · 2024-04-18T13:43:01Z

Might be a dumb question but don't we also want to open a PR with the new run of the use-case or is this just for testing purposes?

What is a PR with the new run? If you mean the updated notebooks, we add a discussion on this.

fd0r · 2024-04-18T13:58:39Z

Might be a dumb question but don't we also want to open a PR with the new run of the use-case or is this just for testing purposes?

What is a PR with the new run? If you mean the updated notebooks, we add a discussion on this.

Thanks for the link to the discussion, makes sense!

fd0r · 2024-04-18T13:59:45Z

script/make_utils/run_use_case_examples.sh

-        echo "*** Processing example ${EXAMPLE_NAME}"
-    else
-        continue
+CURRENT_DIR=$(pwd)


Should we check somehow that the CURRENT_DIR is the root of the repo? or shouldn't we force CURRENT_DIR to the root of the repo?

I am expecting the GH action to put me in the root of the repo. Not sure what path we should force it to. Depends on the GH action I suppose.

$PATH_OF_SCRIPT / .. / .. or something like that? Don't know how easy it is to get from bash. I'm fine with the current solution.

Yes indeed we could use path from script. A bit annoying but maybe safer. I can add this quickly in another PR why not.

Done -> #627 will merge this one first

fd0r

Looks good to me, nice to have a make file per use-case, is this something that should also be used by our users? 🤔

andrei-stoian-zama

Great work! thanks

jfrery requested a review from a team as a code owner September 28, 2023 16:11

cla-bot bot added the cla-signed label Sep 28, 2023

jfrery mentioned this pull request Sep 28, 2023

chore: remove tf warnings at inference #309

Merged

RomanBredehoft reviewed Sep 28, 2023

View reviewed changes

.github/workflows/run_use_cases_examples.yaml Outdated Show resolved Hide resolved

RomanBredehoft previously approved these changes Sep 28, 2023

View reviewed changes

jfrery dismissed RomanBredehoft’s stale review via b49bf6a September 29, 2023 07:12

jfrery force-pushed the chore/add_run_use_case_example branch from 2faa97f to 8c0b84b Compare September 29, 2023 08:21

jfrery force-pushed the chore/add_run_use_case_example branch 2 times, most recently from 1339a20 to d946b95 Compare September 29, 2023 15:14

jfrery closed this Dec 13, 2023

jfrery reopened this Dec 13, 2023

kcelia reviewed Feb 5, 2024

View reviewed changes

use_case_examples/titanic/Makefile Show resolved Hide resolved

fd0r previously approved these changes Feb 5, 2024

View reviewed changes

jfrery dismissed fd0r’s stale review via 3f74619 March 19, 2024 11:34

jfrery force-pushed the chore/add_run_use_case_example branch 2 times, most recently from 3f74619 to 5b77be9 Compare March 19, 2024 15:00

jfrery marked this pull request as draft April 15, 2024 08:22

jfrery force-pushed the chore/add_run_use_case_example branch 8 times, most recently from d35ff40 to b8433a9 Compare April 15, 2024 17:39

jfrery force-pushed the chore/add_run_use_case_example branch from 38cd25e to 33e1cc8 Compare April 17, 2024 12:12

jfrery marked this pull request as ready for review April 17, 2024 12:12

jfrery requested review from RomanBredehoft and andrei-stoian-zama April 17, 2024 12:14

kcelia reviewed Apr 17, 2024

View reviewed changes

use_case_examples/titanic/requirements.txt Outdated Show resolved Hide resolved

kcelia previously approved these changes Apr 17, 2024

View reviewed changes

jfrery dismissed kcelia’s stale review via 0dee236 April 17, 2024 12:29

jfrery commented Apr 17, 2024

View reviewed changes

benchmarks/glm.py Outdated Show resolved Hide resolved

jfrery commented Apr 17, 2024

View reviewed changes

src/concrete/ml/quantization/base_quantized_op.py Outdated Show resolved Hide resolved

jfrery force-pushed the chore/add_run_use_case_example branch from 0dee236 to 5621f00 Compare April 17, 2024 12:39

RomanBredehoft reviewed Apr 17, 2024

View reviewed changes

use_case_examples/cifar/cifar_brevitas_finetuning/cifar_utils.py Outdated Show resolved Hide resolved

RomanBredehoft reviewed Apr 17, 2024

View reviewed changes

script/make_utils/run_use_case_examples.sh Show resolved Hide resolved

jfrery requested a review from RomanBredehoft April 17, 2024 14:11

andrei-stoian-zama requested changes Apr 18, 2024

View reviewed changes

jfrery force-pushed the chore/add_run_use_case_example branch from 868efd9 to 7051a21 Compare April 18, 2024 10:47

jfrery requested a review from andrei-stoian-zama April 18, 2024 10:48

jfrery added 2 commits April 18, 2024 14:13

chore: add run use case example to GH workflow

851fa82

chore: add run one use case example

d97152f

jfrery force-pushed the chore/add_run_use_case_example branch from 7051a21 to d97152f Compare April 18, 2024 12:14

RomanBredehoft approved these changes Apr 18, 2024

View reviewed changes

fd0r reviewed Apr 18, 2024

View reviewed changes

fd0r approved these changes Apr 18, 2024

View reviewed changes

andrei-stoian-zama approved these changes Apr 18, 2024

View reviewed changes

jfrery merged commit a6c06f9 into main Apr 18, 2024
12 checks passed

jfrery deleted the chore/add_run_use_case_example branch April 18, 2024 15:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add run use case example to GH workflow #310

chore: add run use case example to GH workflow #310

jfrery commented Sep 28, 2023 •

edited

Loading

jfrery commented Sep 28, 2023

RomanBredehoft left a comment •

edited

Loading

jfrery commented Sep 28, 2023

andrei-stoian-zama commented Sep 29, 2023

RomanBredehoft commented Dec 13, 2023

jfrery commented Dec 13, 2023

RomanBredehoft Apr 17, 2024 •

edited

Loading

jfrery Apr 17, 2024

RomanBredehoft Apr 17, 2024

jfrery Apr 17, 2024

RomanBredehoft Apr 18, 2024

jfrery Apr 18, 2024

RomanBredehoft left a comment

github-actions bot commented Apr 18, 2024

fd0r left a comment •

edited

Loading

jfrery commented Apr 18, 2024

fd0r commented Apr 18, 2024

fd0r Apr 18, 2024

jfrery Apr 18, 2024

fd0r Apr 18, 2024

jfrery Apr 18, 2024

jfrery Apr 18, 2024

fd0r left a comment

andrei-stoian-zama left a comment

chore: add run use case example to GH workflow #310

chore: add run use case example to GH workflow #310

Conversation

jfrery commented Sep 28, 2023 • edited Loading

jfrery commented Sep 28, 2023

RomanBredehoft left a comment • edited Loading

Choose a reason for hiding this comment

jfrery commented Sep 28, 2023

andrei-stoian-zama commented Sep 29, 2023

RomanBredehoft commented Dec 13, 2023

jfrery commented Dec 13, 2023

RomanBredehoft Apr 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RomanBredehoft left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 18, 2024

Coverage passed ✅

fd0r left a comment • edited Loading

Choose a reason for hiding this comment

jfrery commented Apr 18, 2024

fd0r commented Apr 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fd0r left a comment

Choose a reason for hiding this comment

andrei-stoian-zama left a comment

Choose a reason for hiding this comment

jfrery commented Sep 28, 2023 •

edited

Loading

RomanBredehoft left a comment •

edited

Loading

RomanBredehoft Apr 17, 2024 •

edited

Loading

fd0r left a comment •

edited

Loading