Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: integrate Concrete Python 2.5.0rc1 #367

Merged
merged 7 commits into from
Oct 18, 2023
Merged

chore: integrate Concrete Python 2.5.0rc1 #367

merged 7 commits into from
Oct 18, 2023

Conversation

RomanBredehoft
Copy link
Collaborator

@RomanBredehoft RomanBredehoft commented Oct 16, 2023 •
edited
Loading

Integrate Concrete Python 2.5.0rc1 : the new simulation still does not properly work and is not enabled by default yet

refs https://github.com/zama-ai/concrete-ml-internal/issues/4091

@RomanBredehoft RomanBredehoft requested a review from a team as a code owner October 16, 2023 12:03
@cla-bot cla-bot bot added the cla-signed label Oct 16, 2023
fd0r
fd0r previously approved these changes Oct 16, 2023
View reviewed changes
fd0r
fd0r previously approved these changes Oct 17, 2023
View reviewed changes
@andrei-stoian-zama andrei-stoian-zama self-requested a review October 17, 2023 11:11
andrei-stoian-zama
andrei-stoian-zama requested changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@andrei-stoian-zama andrei-stoian-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, let's keep the old VL for now

andrei-stoian-zama
andrei-stoian-zama approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@andrei-stoian-zama andrei-stoian-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@github-actions
Copy link

Coverage passed ✅

Coverage details 

---------- coverage: platform linux, python 3.8.18-final-0 -----------
Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL    6201      0   100%

51 files skipped due to complete coverage.

@RomanBredehoft RomanBredehoft merged commit 5616b18 into main Oct 18, 2023
@RomanBredehoft RomanBredehoft deleted the chore/integrate_cp_2_5_0_rc1 branch October 18, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrei-stoian-zama andrei-stoian-zama andrei-stoian-zama approved these changes

@fd0r fd0r fd0r approved these changes

@kcelia kcelia kcelia approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RomanBredehoft @kcelia @fd0r @andrei-stoian-zama