Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update commit rule for CI #471

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

RomanBredehoft
Copy link
Collaborator

@RomanBredehoft RomanBredehoft commented Jan 29, 2024

I believe the commit rule could be simplified as we only use this pattern : '^((feat|fix|chore|docs)\:) .+$'

follows the work done in #470

@RomanBredehoft RomanBredehoft requested a review from a team as a code owner January 29, 2024 10:36
@cla-bot cla-bot bot added the cla-signed label Jan 29, 2024
kcelia
kcelia previously approved these changes Jan 29, 2024
Copy link
Collaborator

@kcelia kcelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Collaborator

@fd0r fd0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather keep feat|fix|chore|refactor|style|test|docs for now even if we don't use it that often.

Btw we should probably discuss with other teams on standardization across projects.

Copy link

Coverage passed ✅

Coverage details

---------- coverage: platform linux, python 3.8.18-final-0 -----------
Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL    6966      0   100%

52 files skipped due to complete coverage.

@RomanBredehoft RomanBredehoft merged commit cdb36db into main Jan 31, 2024
10 checks passed
@RomanBredehoft RomanBredehoft deleted the chore/update_commit_rules_in_ci branch January 31, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants