Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix coverage warning when re-running failed tests in CI #473

Merged
merged 1 commit into from
Feb 5, 2024
Merged

chore: fix coverage warning when re-running failed tests in CI #473

merged 1 commit into from
Feb 5, 2024

Conversation

RomanBredehoft
Copy link
Collaborator

in #449, coverage failed but the CI remained green : this is because a flaky test failed and was re-run, but re-runned tests were not considered for coverage warning

this PR should fix this thanks to the --cov-append option

@RomanBredehoft RomanBredehoft requested a review from a team as a code owner January 29, 2024 17:48
@cla-bot cla-bot bot added the cla-signed label Jan 29, 2024
@github-actions GitHub Actions
Copy link

Coverage passed ✅

Coverage details 

---------- coverage: platform linux, python 3.8.18-final-0 -----------
Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL    6966      0   100%

52 files skipped due to complete coverage.

@RomanBredehoft RomanBredehoft merged commit f07092a into main Feb 5, 2024
9 checks passed
@RomanBredehoft RomanBredehoft deleted the chore/fix_coverage_when_re_running_tests branch February 5, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fd0r fd0r fd0r approved these changes

@kcelia kcelia kcelia approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RomanBredehoft @kcelia @fd0r