Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support conv1d operator #484

Merged
merged 1 commit into from
Feb 5, 2024
Merged

feat: support conv1d operator #484

merged 1 commit into from
Feb 5, 2024

Conversation

RomanBredehoft
Copy link
Collaborator

Adds a workaround in Concrete ML for supporting torch's conv1d using conv2d + some unsqueeze/squeeze ops, until it is handled in Concrete Python (https://github.com/zama-ai/concrete-ml-internal/issues/4117)

closes https://github.com/zama-ai/concrete-ml-internal/issues/4109

@RomanBredehoft RomanBredehoft requested a review from a team as a code owner February 5, 2024 13:18
@cla-bot cla-bot bot added the cla-signed label Feb 5, 2024
fd0r
fd0r previously approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@fd0r fd0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

jfrery
jfrery previously approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@jfrery jfrery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature! Thanks

src/concrete/ml/quantization/quantized_ops.py Show resolved Hide resolved
andrei-stoian-zama
andrei-stoian-zama previously approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@andrei-stoian-zama andrei-stoian-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work here!

@RomanBredehoft RomanBredehoft force-pushed the feat/support_conv_1d_4109 branch from 9d30ef6 to 2965066 Compare February 5, 2024 14:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

Coverage passed ✅

Coverage details 

---------- coverage: platform linux, python 3.8.18-final-0 -----------
Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL    7105      0   100%

52 files skipped due to complete coverage.

@RomanBredehoft RomanBredehoft merged commit 09ad7a6 into main Feb 5, 2024
11 checks passed
@RomanBredehoft RomanBredehoft deleted the feat/support_conv_1d_4109 branch February 5, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fd0r fd0r fd0r approved these changes

@jfrery jfrery Awaiting requested review from jfrery

@andrei-stoian-zama andrei-stoian-zama Awaiting requested review from andrei-stoian-zama

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RomanBredehoft @jfrery @fd0r @andrei-stoian-zama