Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix sync repository action (bis) #575

Merged
merged 20 commits into from
Apr 3, 2024

Conversation

RomanBredehoft
Copy link
Collaborator

@RomanBredehoft RomanBredehoft commented Apr 2, 2024

it's still failing : https://github.com/zama-ai/concrete-ml/actions/runs/8522402034/job/23342541783

the issue is that the external action does not provide any LFS options

also, it looks like we were cloning the repo twice, so I remove the external action and simplified to these steps

@RomanBredehoft RomanBredehoft requested a review from a team as a code owner April 2, 2024 13:34
@cla-bot cla-bot bot added the cla-signed label Apr 2, 2024
Copy link
Collaborator

@jfrery jfrery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can test the workflow on this branch maybe first so that you don't have to merge to main to see if it works.

Just comment

    branches:
      - 'main'

@RomanBredehoft
Copy link
Collaborator Author

I'm usually not a fan of doing this when we are doing things related to main, but in this case I think it should be good indeed, will do thanks !

@RomanBredehoft
Copy link
Collaborator Author

I can't find a way to make this work, it's pretty weird

@RomanBredehoft RomanBredehoft force-pushed the chore/fix_sync_repo_action branch 2 times, most recently from 64b73fd to dda8051 Compare April 3, 2024 12:16
@RomanBredehoft RomanBredehoft force-pushed the chore/fix_sync_repo_action branch 2 times, most recently from cdf3434 to 2dd5185 Compare April 3, 2024 12:24
@RomanBredehoft RomanBredehoft force-pushed the chore/fix_sync_repo_action branch from 2dd5185 to bc2bb9d Compare April 3, 2024 12:32
@RomanBredehoft RomanBredehoft force-pushed the chore/fix_sync_repo_action branch from 3cf5bcc to 5a87ccb Compare April 3, 2024 12:42
jfrery
jfrery previously approved these changes Apr 3, 2024
Copy link
Collaborator

@jfrery jfrery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@RomanBredehoft
Copy link
Collaborator Author

finally working 🎉

@RomanBredehoft RomanBredehoft merged commit 4dcd616 into main Apr 3, 2024
12 checks passed
@RomanBredehoft RomanBredehoft deleted the chore/fix_sync_repo_action branch April 3, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants