docs: add dataframe documentation #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we move the |
RomanBredehoft
requested changes
Apr 3, 2024
andrei-stoian-zama
force-pushed
the
docs/add_dataframe_docs_2
branch
from
6b8c73e to
49160a5
Compare
jfrery
approved these changes
Apr 3, 2024
RomanBredehoft
approved these changes
Apr 3, 2024
bcm-at-zama
reviewed
Apr 8, 2024
| - [concrete.ml.torch.hybrid_model.md](references/api/concrete.ml.torch.hybrid_model.md) | ||
| - [concrete.ml.torch.md](references/api/concrete.ml.torch.md) | ||
| - [concrete.ml.torch.numpy_module.md](references/api/concrete.ml.torch.numpy_module.md) | ||
| - [concrete.ml.version.md](references/api/concrete.ml.version.md) |
There was a problem hiding this comment.
not good @andrei-stoian-zama @RomanBredehoft
There was a problem hiding this comment.
answered by andrei here : #576 (comment)
There was a problem hiding this comment.
hum, is it compatible with what we have for Concrete gitbook and is it what was agreed with Yuxi?
by the way, if we remove that, pretty sure we can remove corresponding .sh
There was a problem hiding this comment.
yes it is , basically the API was refered twice in the summary, now it's only available in :
## References
- [API](references/api/README.md)
which is what Yuxi added
I'm not sure what you mean by "the corresponding .sh" but isn't it what I did in #580 ?
There was a problem hiding this comment.
- ok I need to check it's done equivalently on Concrete side, then; it was done differently before I went to vacation, at least
- ah yes indeed, ./script/doc_utils/update_apidocs_files_in_SUMMARY.sh was removed, perfect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.